[PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

Please consider this patch to thinkpad-acpi. This fixes failure to load
on the newer V series Lenovo thinkpads which report the product version
as Lenovo instead of ThinkPad. This Patch was tested by me and found
to work on my Lenovo V series sytem. 

Thanks
Manoj Iyer

[PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

The newer V series bios reports product version as 'Lenovo'
instead of 'ThinkPad'. Recoginze this new string so that
the module can load.

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index ea0c607..d68c000 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -8658,7 +8658,7 @@ static int __must_check __init get_thinkpad_model_data(
 	}
 
 	s = dmi_get_system_info(DMI_PRODUCT_VERSION);
-	if (s && !strnicmp(s, "ThinkPad", 8)) {
+	if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
 		tp->model_str = kstrdup(s, GFP_KERNEL);
 		if (!tp->model_str)
 			return -ENOMEM;
-- 
1.7.9.1

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Henrique de Moraes Holschuh]

On Fri, 09 Mar 2012, Manoj Iyer wrote:
> The newer V series bios reports product version as 'Lenovo'
> instead of 'ThinkPad'. Recoginze this new string so that
> the module can load.
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index ea0c607..d68c000 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8658,7 +8658,7 @@ static int __must_check __init get_thinkpad_model_data(
>  	}
>  
>  	s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> -	if (s && !strnicmp(s, "ThinkPad", 8)) {
> +	if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
>  		tp->model_str = kstrdup(s, GFP_KERNEL);
>  		if (!tp->model_str)
>  			return -ENOMEM;

So far so good, but what driver functionality works well in these new
lenovo boxes?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Yves-Alexis Perez]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
> 
> So far so good, but what driver functionality works well in these new
> lenovo boxes? 

V-series are Ideapad, so I'm not really sure this need to be added to
thinkpad-acpi.

Regards,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Henrique de Moraes Holschuh]

On Sat, 10 Mar 2012, Yves-Alexis Perez wrote:
> On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
> > So far so good, but what driver functionality works well in these new
> > lenovo boxes? 
> 
> V-series are Ideapad, so I'm not really sure this need to be added to
> thinkpad-acpi.

Yeah, it is not a thinkpad, not even in name.

However, it just might have enough of the thinkpad ACPI API to work,
thus my question.  What good does thinkpad-acpi do in a Lenovo Ideapad
V-series?   If it does something useful, we can support it (but it
likely needs more than just this patch to be safe).

If it doesn't do anything useful, consider this as an absolute NACK
(i.e. I will outright revert it if it lands).  Loading thinkpad-acpi on
a notebook that doesn't benefit from it is harmful in the long term, as
thinkpad-acpi can suddenly start calling weird stuff in ACPI on that box
and do something bad.   There is a real reason why we restrict IBM-era
stuff to IBM thinkpads, etc.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

Henrique/Yves-Alexis,

Yes, the V series systems are listed under Ideapad series on Lenovo's 
website. I initially was looking at why the Fn+F5 hotkey was not reporting 
a key event. Looking at the bios dsdt.dsl data on V480 I see

Device (HKEY)
                     {
                         Mutex (BFWM, 0x07)
                         Name (INDV, Zero)
                         Name (_HID, EisaId ("LEN0068"))
                         Method (_STA, 0, NotSerialized)

and it does not have the acpi_device_id of VPC2004 like other ideapads 
that I have seen, and seemed like the HKEY could be handled by 
thinkpad_acpi module. Product version string in DMI says "Lenovo V480" 
instead of "ThinkPad" and this was not recognized by the thinkpad_acpi 
module, thus my quirk to load the module.

After loading the module on the V480 I see:

[14511.946260] thinkpad_acpi: ThinkPad ACPI Extras v0.24
[14511.946262] thinkpad_acpi: http://ibm-acpi.sf.net/
[14511.946264] thinkpad_acpi: ThinkPad BIOS H5ET23WW (0.23 ), EC unknown
[14511.946265] thinkpad_acpi: Lenovo Lenovo V480, model 14TD010
[14511.946707] thinkpad_acpi: detected a 8-level brightness capable 
ThinkPad
[14511.952009] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is 
unblocked
[14511.953099] Registered led device: tpacpi::thinklight
[14511.953156] Registered led device: tpacpi::power
[14511.953203] Registered led device: tpacpi::standby
[14511.953247] Registered led device: tpacpi::thinkvantage
[14511.953262] thinkpad_acpi: Standard ACPI backlight interface available, 
not loading native one
[14511.953420] thinkpad_acpi: Console audio control enabled, mode: monitor 
(read only)
[14511.955196] input: ThinkPad Extra Buttons as 
/devices/platform/thinkpad_acpi/input/input17

Fn+F15 now reports key press event, 00000080 00001005, and it reported 
nothing before when the module was not loaded. So prior to loading 
thinkpad_acpi, /lib/udev/findkeyboards == input/event3, /lib/udev/keymap 
-i input/event3 returned no valid values for Fn+F5 combo.

I am trying to get this patched module tested on other thinkpad and 
ideapads that we have to see if there are any regression or other issues. 
So, please let me know if this something worth supporting.


Thanks
Manoj

On Sat, 10 Mar 2012, Henrique de Moraes Holschuh wrote:

> On Sat, 10 Mar 2012, Yves-Alexis Perez wrote:
>> On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
>>> So far so good, but what driver functionality works well in these new
>>> lenovo boxes?
>>
>> V-series are Ideapad, so I'm not really sure this need to be added to
>> thinkpad-acpi.
>
> Yeah, it is not a thinkpad, not even in name.
>
> However, it just might have enough of the thinkpad ACPI API to work,
> thus my question.  What good does thinkpad-acpi do in a Lenovo Ideapad
> V-series?   If it does something useful, we can support it (but it
> likely needs more than just this patch to be safe).
>
> If it doesn't do anything useful, consider this as an absolute NACK
> (i.e. I will outright revert it if it lands).  Loading thinkpad-acpi on
> a notebook that doesn't benefit from it is harmful in the long term, as
> thinkpad-acpi can suddenly start calling weird stuff in ACPI on that box
> and do something bad.   There is a real reason why we restrict IBM-era
> stuff to IBM thinkpads, etc.
>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Henrique de Moraes Holschuh]

On Mon, 12 Mar 2012, Manoj Iyer wrote:
> Yes, the V series systems are listed under Ideapad series on
> Lenovo's website. I initially was looking at why the Fn+F5 hotkey
> was not reporting a key event. Looking at the bios dsdt.dsl data on
> V480 I see
> 
> Device (HKEY)
>                     {
>                         Mutex (BFWM, 0x07)
>                         Name (INDV, Zero)
>                         Name (_HID, EisaId ("LEN0068"))
>                         Method (_STA, 0, NotSerialized)
> 
> and it does not have the acpi_device_id of VPC2004 like other
> ideapads that I have seen, and seemed like the HKEY could be handled
> by thinkpad_acpi module. Product version string in DMI says "Lenovo
> V480" instead of "ThinkPad" and this was not recognized by the
> thinkpad_acpi module, thus my quirk to load the module.
> 
> After loading the module on the V480 I see:
> 
> [14511.946260] thinkpad_acpi: ThinkPad ACPI Extras v0.24
> [14511.946262] thinkpad_acpi: http://ibm-acpi.sf.net/
> [14511.946264] thinkpad_acpi: ThinkPad BIOS H5ET23WW (0.23 ), EC unknown
> [14511.946265] thinkpad_acpi: Lenovo Lenovo V480, model 14TD010
> [14511.946707] thinkpad_acpi: detected a 8-level brightness capable
> ThinkPad
> [14511.952009] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw:
> radio is unblocked
> [14511.953099] Registered led device: tpacpi::thinklight
> [14511.953156] Registered led device: tpacpi::power
> [14511.953203] Registered led device: tpacpi::standby
> [14511.953247] Registered led device: tpacpi::thinkvantage
> [14511.953262] thinkpad_acpi: Standard ACPI backlight interface
> available, not loading native one
> [14511.953420] thinkpad_acpi: Console audio control enabled, mode:
> monitor (read only)
> [14511.955196] input: ThinkPad Extra Buttons as
> /devices/platform/thinkpad_acpi/input/input17
> 
> Fn+F15 now reports key press event, 00000080 00001005, and it
> reported nothing before when the module was not loaded. So prior to
> loading thinkpad_acpi, /lib/udev/findkeyboards == input/event3,
> /lib/udev/keymap -i input/event3 returned no valid values for Fn+F5
> combo.
> 
> I am trying to get this patched module tested on other thinkpad and
> ideapads that we have to see if there are any regression or other
> issues. So, please let me know if this something worth supporting.

Yes, it looks like it is worth supporting alright.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

>>
>> I am trying to get this patched module tested on other thinkpad and
>> ideapads that we have to see if there are any regression or other
>> issues. So, please let me know if this something worth supporting.
>
> Yes, it looks like it is worth supporting alright.

ok great. So, as I said earlier I will try and get this patched module 
tested on other ideapads to make sure we are not breaking existing 
systems. Unfortunately the systems are with our Taiwan engineers and will 
take a couple of days for them to get back with results.

>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

On Mon, 12 Mar 2012, Manoj Iyer wrote:

>>> 
>>> I am trying to get this patched module tested on other thinkpad and
>>> ideapads that we have to see if there are any regression or other
>>> issues. So, please let me know if this something worth supporting.
>> 
>> Yes, it looks like it is worth supporting alright.
>
> ok great. So, as I said earlier I will try and get this patched module tested 
> on other ideapads to make sure we are not breaking existing systems. 
> Unfortunately the systems are with our Taiwan engineers and will take a 
> couple of days for them to get back with results.

The patch was tested by the following people on ThinkPads, V480, and 
ideapads, and found to work as expected. I am informed that it does not 
break existing thinkpads, and it fixes issues mentioned on the V480. Can 
you please add the following tested-by when you apply the patch to your 
tree?

Tested-by: James Ferguson <james.ferguson@canonical.com>
Tested-by: Dennis Chua <dennis.chua@canonical.com>
Tested-by: Ike Pan <ike.pan@canonical.com>


>
>> 
>> --
>>  "One disk to rule them all, One disk to find them. One disk to bring
>>  them all and in the darkness grind them. In the Land of Redmond
>>  where the shadows lie." -- The Silicon Valley Tarot
>>  Henrique Holschuh
>> 
>> 
>
> --
> ====================
> Manoj Iyer
> Ubuntu/Canonical
> Hardware Enablement
> ====================
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Henrique de Moraes Holschuh]

On Tue, 13 Mar 2012, Manoj Iyer wrote:
> On Mon, 12 Mar 2012, Manoj Iyer wrote:
> >>> I am trying to get this patched module tested on other thinkpad and
> >>> ideapads that we have to see if there are any regression or other
> >>> issues. So, please let me know if this something worth supporting.
> >> 
> >> Yes, it looks like it is worth supporting alright.
> >
> > ok great. So, as I said earlier I will try and get this patched module tested 
> > on other ideapads to make sure we are not breaking existing systems. 
> > Unfortunately the systems are with our Taiwan engineers and will take a 
> > couple of days for them to get back with results.
> 
> The patch was tested by the following people on ThinkPads, V480, and 
> ideapads, and found to work as expected. I am informed that it does not 
> break existing thinkpads, and it fixes issues mentioned on the V480. Can 
> you please add the following tested-by when you apply the patch to your 
> tree?
> 
> Tested-by: James Ferguson <james.ferguson@canonical.com>
> Tested-by: Dennis Chua <dennis.chua@canonical.com>
> Tested-by: Ike Pan <ike.pan@canonical.com>

Very well,

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Matthew, can you please pick it?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Manoj Iyer]

On Tue, 13 Mar 2012, Henrique de Moraes Holschuh wrote:

> On Tue, 13 Mar 2012, Manoj Iyer wrote:
>> On Mon, 12 Mar 2012, Manoj Iyer wrote:
>>>>> I am trying to get this patched module tested on other thinkpad and
>>>>> ideapads that we have to see if there are any regression or other
>>>>> issues. So, please let me know if this something worth supporting.
>>>>
>>>> Yes, it looks like it is worth supporting alright.
>>>
>>> ok great. So, as I said earlier I will try and get this patched module tested
>>> on other ideapads to make sure we are not breaking existing systems.
>>> Unfortunately the systems are with our Taiwan engineers and will take a
>>> couple of days for them to get back with results.
>>
>> The patch was tested by the following people on ThinkPads, V480, and
>> ideapads, and found to work as expected. I am informed that it does not
>> break existing thinkpads, and it fixes issues mentioned on the V480. Can
>> you please add the following tested-by when you apply the patch to your
>> tree?
>>
>> Tested-by: James Ferguson <james.ferguson@canonical.com>
>> Tested-by: Dennis Chua <dennis.chua@canonical.com>
>> Tested-by: Ike Pan <ike.pan@canonical.com>
>
> Very well,
>
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
> Matthew, can you please pick it?

Looks like I fat fingered the list, Matthew got dropped from the cc list 
when I pasted @canonical.com addresses. Sorry Matthew.

>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Matthew Garrett]

On Tue, Mar 13, 2012 at 05:07:45PM -0300, Henrique de Moraes Holschuh wrote:

> Matthew, can you please pick it?

Done.

-- 
Matthew Garrett | mjg59@srcf.ucam.org