From: Vivek Goyal <vgoyal@redhat.com>
To: Shaohua Li <shli@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [RFC]blk: mark discard request sync
Date: Tue, 20 Mar 2012 12:47:57 -0400 [thread overview]
Message-ID: <20120320164757.GG17071@redhat.com> (raw)
In-Reply-To: <4F62EE5E.5070207@kernel.org>
On Fri, Mar 16, 2012 at 03:40:14PM +0800, Shaohua Li wrote:
>
> Subject: blk: mark discard request sync
>
> discard is called in jbd for example. If discard is slowed down, all
> file operations could be impacted (eg, journal is full). And we always
> wait for discard to finish. So looks we should mark discard as sync.
>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
This one is tricky and I am not sure what's the right thing to do.
Generally the philosophy seems to be that request is sync is somebody
is waiting on it. To me even on async writes somebody is waiting (either
file system or a writer which has been throttled). So if we don't do
async writes in reasonable amount of time, we start getting "task blocked
for more than 120 seconds" message.
Do you have some test cases to show how bad the problem is if we don't
issue discard as SYNC request.
Thanks
Vivek
next prev parent reply other threads:[~2012-03-20 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 7:40 [RFC]blk: mark discard request sync Shaohua Li
2012-03-20 16:47 ` Vivek Goyal [this message]
2012-03-21 1:01 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320164757.GG17071@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).