public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 4/5] ktest: Fix SWITCH_TO_GOOD to also reboot the machine
Date: Wed, 21 Mar 2012 12:01:29 -0400	[thread overview]
Message-ID: <20120321160244.156294414@goodmis.org> (raw)
In-Reply-To: 20120321160125.496052559@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

When the option SWITCH_TO_GOOD is set, it will be called when the system
needs to reboot to the good server. But currently, this keeps the reboot
from happening. The SWITCH_TO_GOOD is just a way to get to a new kernel,
it may not mean to not reboot.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/testing/ktest/ktest.pl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 1143e6c..e7fed79 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -1116,7 +1116,6 @@ sub reboot_to_good {
 
     if (defined($switch_to_good)) {
 	run_command $switch_to_good;
-	return;
     }
 
     reboot $time;
-- 
1.7.8.3



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-03-21 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 16:01 [PATCH 0/5] [GIT PULL] ktest for v3.4 Steven Rostedt
2012-03-21 16:01 ` [PATCH 1/5] ktest: Add INSTALL_MOD_STRIP=1 when installing modules Steven Rostedt
2012-03-21 16:01 ` [PATCH 2/5] ktest: Add warning when bugs are ignored Steven Rostedt
2012-03-21 16:01 ` [PATCH 3/5] ktest: Add SCP_TO_TARGET_INSTALL option Steven Rostedt
2012-03-21 16:01 ` Steven Rostedt [this message]
2012-03-21 16:01 ` [PATCH 5/5] ktest: Allow a test to override REBOOT_ON_SUCCESS Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120321160244.156294414@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox