From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH v8] sound/soc/lapis: add machine driver for ML7213 Carrier Board
Date: Wed, 21 Mar 2012 16:11:49 +0000 [thread overview]
Message-ID: <20120321161148.GG3226@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1332292517-3411-1-git-send-email-tomoya.rohm@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Wed, Mar 21, 2012 at 10:15:17AM +0900, Tomoya MORINAGA wrote:
> This machine driver is for
> LAPIS Semiconductor ML7213 Carrier Board + ML26124 Reference Board
This looks good but obviously needs the platform before it can be
merged. One fairly minor thing:
> + mclkfs = clk / params_rate(hw_params);
> + bclkfs = 32;
You no longer use either mclkfs or bclkfs so you could just delete the
code that calculates them - the DAI drivers will work this stuff out for
you now so the machine driver doesn't need to.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-21 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 1:15 [PATCH v8] sound/soc/lapis: add machine driver for ML7213 Carrier Board Tomoya MORINAGA
2012-03-21 16:11 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321161148.GG3226@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).