linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>,
	mingo@elte.hu, paulus@samba.org, cjashfor@linux.vnet.ibm.com,
	fweisbec@gmail.com, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] perf, tool: Add new event group management
Date: Thu, 22 Mar 2012 08:56:34 +0100	[thread overview]
Message-ID: <20120322075634.GD31810@gmail.com> (raw)
In-Reply-To: <20120321151332.GD21163@infradead.org>


* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Wed, Mar 21, 2012 at 01:15:10PM +0100, Ingo Molnar escreveu:
> > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > > I would much prefer a syntax that's more natural but requires 
> > > quoting than one that's quirky and tailor made to avoid 
> > > whatever current bash does. For one, there's other shells out 
> > > there that might have different quoting needs and bash is of 
> > > course free to extend its syntax.
> > 
> > Well, they are unlikely to extend to '+', it would break a 
> > boatload of scripts I suspect.
> > 
> > So the question would be, is a+b+c as event grouping a natural 
> > syntax? If not then lets use a quoted one that is.
> 
>    -e groupname=event1,event2,event3
> 
> Seems intuitive, no?

Hm, if there's no use for 'groupname' later on then it's a 
needlessly unspecified dimension. If this variant is picked then 
I'd suggest to make it a fixed:

  -e group=event1,event2,event3

kind of thing instead.

Thanks,

	Ingo

  reply	other threads:[~2012-03-22  7:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 18:15 [RFC 0/3] perf tool: Add new event group management Jiri Olsa
2012-03-20 18:15 ` [PATCH 1/3] perf, tool: Fix various casting issues for 32 bits Jiri Olsa
2012-03-23  8:29   ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2012-03-20 18:15 ` [PATCH 2/3] perf, tool: Fix modifier to be applied on correct events Jiri Olsa
2012-03-23  8:30   ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2012-03-20 18:15 ` [PATCH 3/3] perf, tool: Add new event group management Jiri Olsa
2012-03-20 18:44   ` Peter Zijlstra
2012-03-20 20:46     ` Ingo Molnar
2012-03-20 22:18       ` Arnaldo Carvalho de Melo
2012-03-21  9:15       ` Peter Zijlstra
2012-03-21  9:52         ` Ingo Molnar
2012-03-21 11:54           ` Peter Zijlstra
2012-03-21 12:15             ` Ingo Molnar
2012-03-21 15:13               ` Arnaldo Carvalho de Melo
2012-03-22  7:56                 ` Ingo Molnar [this message]
2012-03-22 12:41                   ` Arnaldo Carvalho de Melo
2012-03-22 13:54                     ` Ingo Molnar
2012-03-22 14:07                       ` Jiri Olsa
2012-03-20 22:36     ` Jiri Olsa
2012-03-21 11:54       ` Peter Zijlstra
2012-03-21 10:42     ` Jiri Olsa
2012-03-21 15:11       ` Arnaldo Carvalho de Melo
2012-03-21 22:27         ` Jiri Olsa
2012-03-22 12:40           ` Arnaldo Carvalho de Melo
2012-04-10 13:19     ` Jiri Olsa
2012-03-20 20:08   ` Arnaldo Carvalho de Melo
2012-03-20 22:16     ` Jiri Olsa
2012-03-21  2:12   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120322075634.GD31810@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).