From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755633Ab2CVH4k (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Mar 2012 03:56:40 -0400
Received: from mail-wg0-f44.google.com ([74.125.82.44]:37866 "EHLO
	mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751457Ab2CVH4j (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Mar 2012 03:56:39 -0400
Date: Thu, 22 Mar 2012 08:56:34 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        mingo@elte.hu, paulus@samba.org, cjashfor@linux.vnet.ibm.com,
        fweisbec@gmail.com, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] perf, tool: Add new event group management
Message-ID: <20120322075634.GD31810@gmail.com>
References: <1332267341-26338-1-git-send-email-jolsa@redhat.com>
 <1332267341-26338-4-git-send-email-jolsa@redhat.com>
 <1332269081.18960.444.camel@twins>
 <20120320204625.GA17142@gmail.com>
 <1332321311.18960.474.camel@twins>
 <20120321095211.GA11122@gmail.com>
 <1332330852.18960.482.camel@twins>
 <20120321121510.GA4386@gmail.com>
 <20120321151332.GD21163@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120321151332.GD21163@infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

> Em Wed, Mar 21, 2012 at 01:15:10PM +0100, Ingo Molnar escreveu:
> > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > > I would much prefer a syntax that's more natural but requires 
> > > quoting than one that's quirky and tailor made to avoid 
> > > whatever current bash does. For one, there's other shells out 
> > > there that might have different quoting needs and bash is of 
> > > course free to extend its syntax.
> > 
> > Well, they are unlikely to extend to '+', it would break a 
> > boatload of scripts I suspect.
> > 
> > So the question would be, is a+b+c as event grouping a natural 
> > syntax? If not then lets use a quoted one that is.
> 
>    -e groupname=event1,event2,event3
> 
> Seems intuitive, no?

Hm, if there's no use for 'groupname' later on then it's a 
needlessly unspecified dimension. If this variant is picked then 
I'd suggest to make it a fixed:

  -e group=event1,event2,event3

kind of thing instead.

Thanks,

	Ingo