From: "Andreas Bießmann" <andreas@biessmann.de>
To: linux-kernel@vger.kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Michal Marek <mmarek@suse.cz>,
Matt Fleming <matt.fleming@intel.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] x86, build: remove unused include
Date: Thu, 22 Mar 2012 11:17:19 +0100 [thread overview]
Message-ID: <20120322101719.GC1406@localhost> (raw)
In-Reply-To: <1329324589-26907-1-git-send-email-andreas@biessmann.de>
On Wed, Feb 15, 2012 at 05:49:49PM +0100, Andreas Bießmann wrote:
> Commit 079f85e624189292d1c818b47764916bf8cf84a8 removed necessity for
> sys/sysmacros.h include but missed to remove the include.
>
> Still requiring sys/sysmacros.h for build tool breaks cross compiling x86 kernel
> on non linux style systems which may not offer sys/sysmacros.h.
>
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
> arch/x86/boot/tools/build.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
> index 4e9bd6b..52628cd 100644
> --- a/arch/x86/boot/tools/build.c
> +++ b/arch/x86/boot/tools/build.c
> @@ -29,7 +29,6 @@
> #include <stdarg.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> -#include <sys/sysmacros.h>
> #include <unistd.h>
> #include <fcntl.h>
> #include <sys/mman.h>
> --
are there any objections against that patch? could anyone take it if not?
next prev parent reply other threads:[~2012-03-22 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 16:49 [PATCH] x86, build: remove unused include Andreas Bießmann
2012-03-22 10:17 ` Andreas Bießmann [this message]
2012-03-22 18:30 ` H. Peter Anvin
2012-03-22 19:44 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322101719.GC1406@localhost \
--to=andreas@biessmann.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox