From: Andrew Morton <akpm@linux-foundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
<eric.dumazet@gmail.com>, <vapier@gentoo.org>, <asharma@fb.com>
Subject: Re: [PATCH] fs/notify/notification.c: make subsys_initcall function static
Date: Thu, 22 Mar 2012 15:00:19 -0700 [thread overview]
Message-ID: <20120322150019.eff74bc8.akpm@linux-foundation.org> (raw)
In-Reply-To: <201203211145.17416.hartleys@visionengravers.com>
On Wed, 21 Mar 2012 11:45:17 -0700
H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> subsys_initcall functions should be marked static.
Well, I suppose there are legitimate situations where they could be
non-static(?), although those would be rather bizarre.
A better reason for making this static is that it has no references
outside this file.
prev parent reply other threads:[~2012-03-22 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 18:45 [PATCH] fs/notify/notification.c: make subsys_initcall function static H Hartley Sweeten
2012-03-22 22:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322150019.eff74bc8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=asharma@fb.com \
--cc=eric.dumazet@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox