From: Ingo Molnar <mingo@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] x86: io_apic: Move and reenable irq only when CONFIG_GENERIC_PENDING_IRQ=y
Date: Fri, 23 Mar 2012 13:46:21 +0100 [thread overview]
Message-ID: <20120323124621.GA6272@gmail.com> (raw)
In-Reply-To: <20120323124525.GB21907@dhcp-26-207.brq.redhat.com>
* Alexander Gordeev <agordeev@redhat.com> wrote:
> On Fri, Mar 23, 2012 at 01:35:03PM +0100, Ingo Molnar wrote:
> >
> > * Alexander Gordeev <agordeev@redhat.com> wrote:
> >
> > > When CONFIG_GENERIC_PENDING_IRQ=n irq move and reenable code
> > > is never get executed, nor do_unmask_irq variable updates its
> > > init value. Move the code under CONFIG_GENERIC_PENDING_IRQ
> > > macro.
> >
> > It's not clear from the changelog what it does though, and the
> > #ifdefs are quite a mess. Does the patch fix some real bug? Or
> > does it remove dead code from certain .config variations?
>
> It just removes a dead code. Can reword if it worth it.
No need to resend, I'll add this detail.
Thanks,
Ingo
next prev parent reply other threads:[~2012-03-23 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 14:19 [PATCH V2] x86: io_apic: Move and reenable irq only when CONFIG_GENERIC_PENDING_IRQ=y Alexander Gordeev
2012-03-23 12:35 ` Ingo Molnar
2012-03-23 12:45 ` Alexander Gordeev
2012-03-23 12:46 ` Ingo Molnar [this message]
2012-03-23 19:46 ` [tip:x86/urgent] x86/io_apic: " tip-bot for Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323124621.GA6272@gmail.com \
--to=mingo@kernel.org \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox