From: Ingo Molnar <mingo@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, paulmck@linux.vnet.ibm.com, fweisbec@gmail.com,
josh@joshtriplett.org, tj@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Merge x86_32 and x86_64 cpu_idle()
Date: Sat, 24 Mar 2012 08:25:19 +0100 [thread overview]
Message-ID: <20120324072519.GB20145@gmail.com> (raw)
In-Reply-To: <1332526838-18305-1-git-send-email-richard@nod.at>
* Richard Weinberger <richard@nod.at> wrote:
> Both functions are mostly identical, so we can merge them.
Okay, so while looking at the patch I got a bit worried about
the 'mostly' qualifier ;-)
You could ease that worry by adding an explanation to the
changelog that itemizes the differences, explains which
architecture is affected by the changes in what way and gives us
the warm fuzzy feeling that everything has been considered and
no ill can come out of using a 'mostly' identical idling
function in the future.
( You should also pick up Frederic's ack for the next
submission of this patch. )
Thanks,
Ingo
next prev parent reply other threads:[~2012-03-24 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 20:18 [PATCH] x86: Merge x86_32 and x86_64 cpu_idle() Richard Weinberger
2012-03-16 21:22 ` H. Peter Anvin
2012-03-16 21:40 ` [PATCH v2] " Richard Weinberger
2012-03-19 13:05 ` Frederic Weisbecker
2012-03-23 12:25 ` Ingo Molnar
2012-03-23 12:31 ` Richard Weinberger
2012-03-23 12:33 ` Ingo Molnar
2012-03-23 18:20 ` [PATCH] " Richard Weinberger
2012-03-24 7:25 ` Ingo Molnar [this message]
2012-03-25 21:00 ` Richard Weinberger
2012-03-26 15:31 ` [tip:x86/urgent] x86: Merge the x86_32 and x86_64 cpu_idle() functions tip-bot for Richard Weinberger
2012-03-16 23:04 ` [PATCH] checkpatch.pl: Check for functions without a real prototype Richard Weinberger
2012-03-16 23:31 ` Joe Perches
2012-03-16 23:35 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324072519.GB20145@gmail.com \
--to=mingo@kernel.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox