From: Grant Likely <grant.likely@secretlab.ca>
To: Karol Lewandowski <k.lewandowsk@samsung.com>
Cc: t.stanislaws@samsung.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, thomas.abraham@linaro.org,
m.szyprowski@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH 2/2] s5p-tv: Add initial DT-support for HDMIPHY
Date: Sat, 24 Mar 2012 19:03:53 +0000 [thread overview]
Message-ID: <20120324190353.8CBE03E0AD3@localhost> (raw)
In-Reply-To: <4F6C5E74.60104@samsung.com>
On Fri, 23 Mar 2012 12:28:52 +0100, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
> On 18.03.2012 19:24, Grant Likely wrote:
>
> > On Fri, 16 Mar 2012 16:42:12 +0100, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
> >> Make it possible to instantiate driver from device tree description.
> >>
> >> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> >> ---
> >> drivers/media/video/s5p-tv/hdmiphy_drv.c | 10 ++++++++++
> >> 1 files changed, 10 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/media/video/s5p-tv/hdmiphy_drv.c b/drivers/media/video/s5p-tv/hdmiphy_drv.c
> >> index 6693f4a..ddf3008 100644
> >> --- a/drivers/media/video/s5p-tv/hdmiphy_drv.c
> >> +++ b/drivers/media/video/s5p-tv/hdmiphy_drv.c
> >> @@ -18,6 +18,7 @@
> >> #include <linux/interrupt.h>
> >> #include <linux/irq.h>
> >> #include <linux/err.h>
> >> +#include <linux/of.h>
> >>
> >> #include <media/v4l2-subdev.h>
> >>
> >> @@ -165,10 +166,19 @@ static const struct i2c_device_id hdmiphy_id[] = {
> >> };
> >> MODULE_DEVICE_TABLE(i2c, hdmiphy_id);
> >>
> >> +#ifdef CONFIG_OF
> >> +static struct of_device_id hdmiphy_dt_match[] = {
> >> + { .compatible = "samsung,s5pv210-hdmiphy" },
> >
> > Ditto here; needs to be listed in documentation.
>
>
> As these drivers require only irq and io address may add these to
> something like [bindings/arm/samsung/]trivial-devices.txt (like it's
> done for i2c)?
yes. I just want the values in the documentation where they can be
searched for.
g.
prev parent reply other threads:[~2012-03-25 0:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 15:42 [PATCH v2 0/2] [media] s5p-tv: Add initial DT-support to s5p-tv's subdevices Karol Lewandowski
2012-03-16 15:42 ` [PATCH 1/2] s5p-tv: Add initial DT-support for TV mixer Karol Lewandowski
2012-03-18 18:24 ` Grant Likely
2012-03-16 15:42 ` [PATCH 2/2] s5p-tv: Add initial DT-support for HDMIPHY Karol Lewandowski
2012-03-18 18:24 ` Grant Likely
2012-03-23 11:28 ` Karol Lewandowski
2012-03-24 19:03 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324190353.8CBE03E0AD3@localhost \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=k.lewandowsk@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.stanislaws@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox