Re: [PATCH 2/2] s5p-tv: Add initial DT-support for HDMIPHY

Karol Lewandowski
2012-03-23T11:28:52Z

On 18.03.2012 19:24, Grant Likely wrote:

> On Fri, 16 Mar 2012 16:42:12 +0100, Karol Lewandowski <k.lewandowsk@samsung.com> wrote:
>> Make it possible to instantiate driver from device tree description.
>>
>> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
>> ---
>> drivers/media/video/s5p-tv/hdmiphy_drv.c | 10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/s5p-tv/hdmiphy_drv.c b/drivers/media/video/s5p-tv/hdmiphy_drv.c
>> index 6693f4a..ddf3008 100644
>> --- a/drivers/media/video/s5p-tv/hdmiphy_drv.c
>> +++ b/drivers/media/video/s5p-tv/hdmiphy_drv.c
>> @@ -18,6 +18,7 @@
>> #include <linux/interrupt.h>
>> #include <linux/irq.h>
>> #include <linux/err.h>
>> +#include <linux/of.h>
>>
>> #include <media/v4l2-subdev.h>
>>
>> @@ -165,10 +166,19 @@ static const struct i2c_device_id hdmiphy_id[] = {
>> };
>> MODULE_DEVICE_TABLE(i2c, hdmiphy_id);
>>
>> +#ifdef CONFIG_OF
>> +static struct of_device_id hdmiphy_dt_match[] = {
>> + { .compatible = "samsung,s5pv210-hdmiphy" },
>
> Ditto here; needs to be listed in documentation.

As these drivers require only irq and io address may add these to
something like [bindings/arm/samsung/]trivial-devices.txt (like it's
done for i2c)?

Thanks for review!
--
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform