From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755275Ab2CYJQp (ORCPT ); Sun, 25 Mar 2012 05:16:45 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:55990 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754855Ab2CYJQo (ORCPT ); Sun, 25 Mar 2012 05:16:44 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sun, 25 Mar 2012 11:16:38 +0200 From: Stefan Richter To: Stefan Richter Cc: Matthew Garrett , Subject: Re: PCIe ASPM: new Kconfig prompt without help text Message-ID: <20120325111638.2afa6281@stein> In-Reply-To: <20120325110508.4167f140@stein> References: <20120325110508.4167f140@stein> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 25 Stefan Richter wrote: > > $ make oldconfig > > PCI Express ASPM control (PCIEASPM) [Y/?] y > > Debug PCI Express ASPM (PCIEASPM_DEBUG) [N/y/?] n > > Default ASPM policy > > > 1. BIOS default (PCIEASPM_DEFAULT) (NEW) > > 2. Powersave (PCIEASPM_POWERSAVE) (NEW) > > 3. Performance (PCIEASPM_PERFORMANCE) (NEW) > > choice[1-3]: ? > > > > There is no help available for this option. > > Choices, choices. Can we get a little explanation here what option should > be chosen in which environments? I am noticing now that there are actually brief help texts at each option, and "make xconfig" for example is able to show them (and that PCIEASPM_DEFAULT is suggested as default value in xconfig). But the "make oldconfig" case is evidently left out in the cold WRT meaning of the choices and which one should be preferred if in doubt. -- Stefan Richter -=====-===-- --== ==--= http://arcgraph.de/sr/