public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Guan Xin <guanx.bac@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Remove over-broad module alias from zaurus.
Date: Mon, 26 Mar 2012 08:49:29 -0400	[thread overview]
Message-ID: <20120326124929.GA4190@redhat.com> (raw)
In-Reply-To: <CANeMGR5xS6GwG18q5QnKt5_pWJB4fEKFoywZDx=kA_JFVREGxw@mail.gmail.com>

On Mon, Mar 26, 2012 at 10:39:48AM +0200, Guan Xin wrote:
 > > On Fri, 17 Jun 2011 20:02:10 -0400, Dave Jones wrote:
 > > This module and a bunch of dependancies are getting loaded on several
 > > of laptops I have (probably picking up the mobile broadband device),
 > > that have nothing to do with zaurus. Matching by class without
 > > any vendor/device pair isn't the right thing to do here, as it
 > > will prevent any other driver from correctly binding to it.
 > > (Or in the absense of a driver, will just waste time & memory by
 > >  unnecessarily loading modules)
 > >
 > > Signed-off-by: Dave Jones <davej@redhat.com>
 > > -	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
 > > -			USB_CDC_PROTO_NONE),
 > > -	.driver_info = (unsigned long) &bogus_mdlm_info,
 > > -}, {
 > >  	/* Motorola MOTOMAGX phones */
 > >  	USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM,
 > >  			USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
 > 
 > After removal of this, my Motorola Rokr E6 (22b8:6027) cannot be recognized.
 > Can this be added back with more specific device info, just like the
 > Motorola MOTOMAGX phones?

Yes, just cut-n-paste one of the other entries, change the ID,
make sure it works and send a diff.

	Dave

  reply	other threads:[~2012-03-26 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  8:39 Remove over-broad module alias from zaurus Guan Xin
2012-03-26 12:49 ` Dave Jones [this message]
2012-03-26 13:14   ` Guan Xin
2012-03-26 13:22     ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2011-06-18  0:02 Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120326124929.GA4190@redhat.com \
    --to=davej@redhat.com \
    --cc=guanx.bac@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox