From: Dave Jones <davej@redhat.com>
To: Guan Xin <guanx.bac@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Remove over-broad module alias from zaurus.
Date: Mon, 26 Mar 2012 09:22:27 -0400 [thread overview]
Message-ID: <20120326132227.GA22887@redhat.com> (raw)
In-Reply-To: <CANeMGR7-_sDbkSXKJd0svEn0R983WNoaVnDdgBU6OzBt67Db+w@mail.gmail.com>
On Mon, Mar 26, 2012 at 03:14:00PM +0200, Guan Xin wrote:
> On Mon, Mar 26, 2012 at 2:49 PM, Dave Jones <davej@redhat.com> wrote:
> > Yes, just cut-n-paste one of the other entries, change the ID,
> > make sure it works and send a diff.
> >
> This patch is tested to work with 2.6.39.4 and 3.2.13.
>
> --- a/drivers/net/usb/zaurus.c 2012-03-26 14:59:36.702998639 +0200
> +++ b/drivers/net/usb/zaurus.c 2012-03-26 15:02:16.860801959 +0200
> @@ -332,6 +332,11 @@
> .driver_info = ZAURUS_PXA_INFO,
> },
> {
> + /* Motorola Rokr E6 */
> + USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6027, USB_CLASS_COMM,
> + USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
> + .driver_info = (unsigned long) &bogus_mdlm_info,
> +}, {
> /* Motorola MOTOMAGX phones */
> USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM,
> USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
>
Looks good, but needs a Signed-off-by: line. See Documentation/SubmittingPatches
(Also Cc: netdev@vger.kernel.org so it gets picked up by patchwork)
thanks,
Dave
next prev parent reply other threads:[~2012-03-26 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 8:39 Remove over-broad module alias from zaurus Guan Xin
2012-03-26 12:49 ` Dave Jones
2012-03-26 13:14 ` Guan Xin
2012-03-26 13:22 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-18 0:02 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326132227.GA22887@redhat.com \
--to=davej@redhat.com \
--cc=guanx.bac@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox