From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"keir.xen@gmail.com" <keir.xen@gmail.com>,
Jan Beulich <jbeulich@suse.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [Xen-devel] [PATCH 1/2] RFC: Prepare PAD for native and xen platform
Date: Mon, 26 Mar 2012 12:48:35 -0400 [thread overview]
Message-ID: <20120326164835.GE10236@phenom.dumpdata.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC8292335105EFA@SHSMSX101.ccr.corp.intel.com>
> > Compare approaches:
> >
> > 1. xen overwritten approach (patches V2, x86_init, osl approach)
> > Pros:
> > a little simpler code
> > Cons:
> > 1). specific to xen, cannot extend to other virt platform;
> > 2). need to change natvie acpi_pad as modular;
> >
> > 2. paravirt interface approach (original patches V1)
> > Pros:
> > 1). standard hypervisor-agnostic interface (USENIX conference
> > 2006), can easily hook to Xen/lguest/... on demand; 2). arch
> > independent; 3). no need to change native acpi_pad as
> > non-modular; Cons:
> > a little complicated code, and code patching is some
> > overkilled for this case (but no harm);
> >
> > (BTW, in the future we need add more and more pv ops, like pv_pm_ops,
> > pv_cpu_hotplug_ops, pv_mem_hotplug_ops, etc. So how about add a
> > pv_misc_ops template to handle them all? seems it's a common issue).
> >
I think (and you probabaly have a better idea) is that the maintainer of
drivers/acpi/* is not very open to adding in code that only benefits Xen.
If it benefits other architectures (say ARM) then adding in hooks there
(in osl for example) makes sense - but I am not sure if ARM has a form
of _PUR code/calls it needs to do.
So with that in mind, neither of those options seems proper - as all of them
depend on changing something in drivers/acpi/*.
I've one or two suggestions of what could be done to still make this
work, but I need you to first see what happens if the native acpi_pad
runs under Xen with the latest upstream code (along with three patches
that are in a BZ I pointed you too).
next prev parent reply other threads:[~2012-03-27 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:29 [PATCH 1/2] RFC: Prepare PAD for native and xen platform Liu, Jinsong
2012-02-23 14:54 ` Jan Beulich
2012-02-23 16:58 ` Liu, Jinsong
2012-02-24 8:37 ` Jan Beulich
2012-02-26 8:25 ` Liu, Jinsong
2012-02-26 17:34 ` Konrad Rzeszutek Wilk
2012-02-28 16:24 ` Liu, Jinsong
2012-02-29 8:01 ` [Xen-devel] " Liu, Jinsong
2012-03-26 7:21 ` Liu, Jinsong
2012-03-26 16:48 ` Konrad Rzeszutek Wilk [this message]
2012-03-29 7:04 ` Liu, Jinsong
2012-03-29 7:27 ` Liu, Jinsong
2012-03-29 18:08 ` Konrad Rzeszutek Wilk
2012-03-30 7:05 ` Liu, Jinsong
2012-03-30 21:13 ` Konrad Rzeszutek Wilk
2012-04-05 13:01 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326164835.GE10236@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@intel.com \
--cc=keir.xen@gmail.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox