From: Andrew Lunn <andrew@lunn.ch>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org,
Sylver Bruneau <sylver.bruneau@googlemail.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Andrew Lunn <andrew@lunn.ch>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH RFT v2] watchdog: Convert orion_wdt driver to watchdog core
Date: Mon, 26 Mar 2012 19:36:24 +0200 [thread overview]
Message-ID: <20120326173624.GA12884@lunn.ch> (raw)
In-Reply-To: <20120326141233.GR2484@titan.lakedaemon.net>
> > static int __devinit orion_wdt_probe(struct platform_device *pdev)
> > @@ -241,26 +146,28 @@ static int __devinit orion_wdt_probe(struct platform_device *pdev)
> > struct resource *res;
> > int ret;
> >
> > - if (pdata) {
> > - wdt_tclk = pdata->tclk;
> > - } else {
> > + if (!pdata) {
> > pr_err("misses platform data\n");
> > return -ENODEV;
> > }
>
> Platform data is changing soon with devicetree support (and converting
> to common clock). Please don't change this if you don't need to.
>
> Also, I'll include Andrew Lunn in the CC. He's doing the conversion of
> orion over to common clock, which affects this driver.
Yep,
Once the merge is over and the first -rc kernel is released, i will
post my patches rebased on that. For wdt, clk is no longer in the
platform data.
Andrew
prev parent reply other threads:[~2012-03-26 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 11:29 [PATCH RFT v2] watchdog: Convert orion_wdt driver to watchdog core Axel Lin
2012-03-26 14:12 ` Jason Cooper
2012-03-26 17:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326173624.GA12884@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=axel.lin@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=sylver.bruneau@googlemail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox