From: Arnd Bergmann <arnd@arndb.de>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compat: use sys_sendfile64() implementation for sendfile syscall
Date: Mon, 26 Mar 2012 20:45:15 +0000 [thread overview]
Message-ID: <201203262045.16243.arnd@arndb.de> (raw)
In-Reply-To: <201203262036.q2QKaZ7U009929@farm-0012.internal.tilera.com>
On Monday 26 March 2012, Chris Metcalf wrote:
> <asm-generic/unistd.h> was set up to use sys_sendfile() for the 32-bit
> compat API instead of sys_sendfile64(), but in fact the right thing to
> do is to use sys_sendfile64() in all cases. The 32-bit sendfile64() API
> in glibc uses the sendfile64 syscall, so it has to be capable of doing
> full 64-bit operations. But the sys_sendfile() kernel implementation
> has a MAX_NON_LFS test in it which explicitly limits the offset to 2^32.
> So, we need to use the sys_sendfile64() implementation in the kernel
> for this case.
>
> Cc: <stable@kernel.org>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2012-03-26 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 20:26 [PATCH] compat: use sys_sendfile64() implementation for sendfile syscall Chris Metcalf
2012-03-26 20:45 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203262045.16243.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox