From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359Ab2CZXOO (ORCPT ); Mon, 26 Mar 2012 19:14:14 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:46099 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431Ab2CZXON (ORCPT ); Mon, 26 Mar 2012 19:14:13 -0400 Date: Tue, 27 Mar 2012 01:14:08 +0200 From: Ingo Molnar To: Andrew Morton Cc: Daniel Drake , mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, dilinger@queued.net, pgf@laptop.org Subject: Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands Message-ID: <20120326231408.GA7495@gmail.com> References: <20120326180710.8DF9C9D401E@zog.reactivated.net> <20120326142908.c5248aec.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120326142908.c5248aec.akpm@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andrew Morton wrote: > > Signed-off-by: Daniel Drake > > Originally-from: Paul Fox > > Cc: Ingo Molnar > > Cc: Thomas Gleixner > > Cc: "H. Peter Anvin" > > Cc: Andres Salomon > > > > ... > > > > v4: really fix sign-off tags > > s/fix/break/? "Originally-from" is not a recognised tag. If this code > is based upon an earlier version from Paul then Signed-off-by: is > correct. No, the original ordering was *not* correct: From: Daniel Drake [...] Signed-off-by: Daniel Drake Signed-off-by: Paul Fox In the previous discussion we had I explained what the rules for signoffs are. Let me quote Linus as well: " The sign-off chain should be very simple: the first person to sign off should be the author, and the last person to sign off should be the committer. " https://lkml.org/lkml/2012/3/22/489 This is not true for this patch, because the first signoff does not match the 'From:' line (author). Nor is the last signoff the committer - i.e. the person sending me this patch to apply. Every maintainer along the route adds a signoff to the tail if it's propagated via email, or does a merge commit if it's a pull. If Daniel sends me a patch he should be the last signoff. If he authored the patch then he should also be the first (and, by implication, only) signoff. Signed-off-by does not recognize multiple authorship - that has to be written into the changelog, added via another type of tag - either approach is fine to me. What I cannot do is to apply patches that have visibly broken signoff chains. Thanks, Ingo