From: Wolfram Sang <w.sang@pengutronix.de>
To: Peter Rusko <rusko.peter@prolan.hu>
Cc: Grant Likely <grant.likely@secretlab.ca>, linux-kernel@vger.kernel.org
Subject: Re: PCA GPIO interrupt triggers, matrix-keypad
Date: Tue, 27 Mar 2012 09:54:47 +0200 [thread overview]
Message-ID: <20120327075447.GA6790@pengutronix.de> (raw)
In-Reply-To: <4F704490.7000308@prolan.hu>
[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]
On Mon, Mar 26, 2012 at 12:27:28PM +0200, Peter Rusko wrote:
> >? I fail to see why having EDGE_FALLING together with EDGE_RISING is not
> >supported. Are you sure you didn't use some other IRQ_TYPE here?
> >
> Yes, you're right, the problem is not there.
It was the most likely answer looking at how IRQ_TYPE_EDGE_BOTH is
defined.
>
> >>I think, this patch should work:
> >
> >Think? Can't you test it :)
> I wish that could be that simple :)
>
> I can test it with the matrix-keypad driver. But there's an inverter
> (+delay) in the circuit (to prevent contact bounce) and I don't know how
> it affects the signals. But in the end sometimes I don't get e.g. the
> key-release event.
It would be great if you could find out, since it might result in
arbitrary patches otherwise which would be a waste of time to review.
> Another change in the code was with the IRQ request. I could only make
> the matrix-keypad driver working with threaded interrupts:
[...]
> Is this okay, or is there another way?
The change itself is basically correct, but you need to make a proper
patch out of it. Please read Documentation/SubmittingPatches (also
Documentation/development-process/ if you haven't already) how to
generate one. Look at other threaded irq users how to convert properly
(you are missing something). Please CC me to the generated patch.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-03-27 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 15:58 PCA GPIO interrupt triggers Peter Rusko
2012-03-24 17:02 ` Grant Likely
2012-03-25 7:40 ` Wolfram Sang
2012-03-26 10:27 ` PCA GPIO interrupt triggers, matrix-keypad Peter Rusko
2012-03-27 7:54 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327075447.GA6790@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rusko.peter@prolan.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox