From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Keith Packard <keithp@keithp.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Chris Wilson <chris@chris-wilson.co.uk>,
Benson Leung <bleung@chromium.org>,
Yufeng Shen <miletus@chromium.org>
Subject: Re: [PATCH 02/11 v3] drm/i915/intel_i2c: assign HDMI port D to pin pair 6
Date: Tue, 27 Mar 2012 09:54:48 +0200 [thread overview]
Message-ID: <20120327075448.GC4276@phenom.ffwll.local> (raw)
In-Reply-To: <CAGS+omAkRiVMJCEK5eyEvWrVEZxCqyjkd3ocNZq=69mC29o-PA@mail.gmail.com>
On Tue, Mar 27, 2012 at 01:49:51AM +0800, Daniel Kurtz wrote:
> I'm not sure what a "Bspec" is, but here is the documents I used:
>
> [DevSNB+]: http://intellinuxgraphics.org/documentation/SNB/IHD_OS_Vol3_Part3.pdf
> Section 2.2.2 lists the 6 gmbus ports (gpio pin pairs):
> [ 5: HDMI/DPD, 4: HDMIB, 3: HDMI/DPC, 2: LVDS, 1: SSC, 0: VGA ]
> 2.2.2.1 lists the GPIO registers to control these 6 ports.
> 2.2.3.1 lists the mapping between 5 of these gmbus ports and the 3
> Pin_Pair_Select bits (of the GMBUS0 register). This table is missing
> HDMIB (port 101).
>
> [DevIBX]: http://intellinuxgraphics.org/IHD_OS_Vol3_Part3r2.pdf
> Section 2.2.2 lists the same 6 gmbus ports plus two 'reserved' gpio ports.
> 2.2.2.1 lists 8 GPIO registers... however, it says the size of the
> block is 6x32, which implies that those 2 reserved GPIO registers
> (GPIO_6 & GPIO_7) don't actually exist (or are irrelevant).
> 2.2.3.1 lists the mapping between the 6 named gmbus ports and the 3
> Pin_Pair_Select bits (of the GMBUS0 register). This table has HDMIB.
Exactly this. Bspec is the internal name for what these public docs are
based on. When fixing up an inconsistency wrt the docs it's always good to
cite it like this, so that later on people can cross check. And we need
section numbers because they are the most stable - Internal Bspec is just
a collection of individual sections as html pages. And hw people also tend
to use the same sections for the same stuff in newer/older chips.
Cheers, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-03-27 7:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 14:26 [PATCH 00/11 v3] fix gmbus writes and related issues Daniel Kurtz
2012-03-26 14:26 ` [PATCH 01/11 v3] drm/i915/intel_i2c: cleanup Daniel Kurtz
2012-03-26 15:29 ` Daniel Vetter
2012-03-26 14:26 ` [PATCH 02/11 v3] drm/i915/intel_i2c: assign HDMI port D to pin pair 6 Daniel Kurtz
2012-03-26 14:47 ` Daniel Vetter
2012-03-26 15:08 ` Daniel Vetter
2012-03-26 17:49 ` Daniel Kurtz
2012-03-27 7:54 ` Daniel Vetter [this message]
2012-03-26 14:26 ` [PATCH 03/11 v3] drm/i915/intel_i2c: use i2c pre/post_xfer functions to setup gpio xfers Daniel Kurtz
2012-03-26 14:49 ` Daniel Vetter
2012-03-26 17:58 ` Daniel Kurtz
2012-03-26 19:06 ` Daniel Vetter
2012-03-26 14:26 ` [PATCH 04/11 v3] drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments Daniel Kurtz
2012-03-26 15:10 ` Daniel Vetter
2012-03-26 15:20 ` Daniel Vetter
2012-03-26 14:26 ` [PATCH 05/11 v3] drm/i915/intel_i2c: allocate gmbus array as part of drm_i915_private Daniel Kurtz
2012-03-26 15:10 ` Daniel Vetter
2012-03-26 15:20 ` Daniel Vetter
2012-03-26 14:26 ` [PATCH 06/11 v3] drm/i915/intel_i2c: refactor using intel_gmbus_get_adapter Daniel Kurtz
2012-03-26 15:22 ` Daniel Vetter
2012-03-26 14:26 ` [PATCH 07/11 v3] drm/i915/intel_i2c: handle zero-length writes Daniel Kurtz
2012-03-26 14:26 ` [PATCH 08/11 v3] drm/i915/intel_i2c: always wait for IDLE before clearing NAK Daniel Kurtz
2012-03-26 14:26 ` [PATCH 09/11 v3] drm/i915/intel_i2c: use WAIT cycle, not STOP Daniel Kurtz
2012-03-26 14:26 ` [PATCH 10/11 v3] drm/i915/intel_i2c: use INDEX cycles for i2c read transactions Daniel Kurtz
2012-03-26 14:26 ` [PATCH 11/11 v3] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop Daniel Kurtz
2012-03-26 15:33 ` [PATCH 00/11 v3] fix gmbus writes and related issues Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327075448.GC4276@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=bleung@chromium.org \
--cc=chris@chris-wilson.co.uk \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox