From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [RFC] perf tools: Including pre-generated flex files
Date: Tue, 27 Mar 2012 15:15:47 -0300 [thread overview]
Message-ID: <20120327181547.GA7374@infradead.org> (raw)
Hi Linus,
We now use lex and bison for the events and PMU parser:
[acme@sandy linux]$ wc -l tools/perf/util/*.[yl]
126 tools/perf/util/parse-events.l
229 tools/perf/util/parse-events.y
43 tools/perf/util/pmu.l
93 tools/perf/util/pmu.y
491 total
Jiri and Peter agreed on having pre-generated files:
[acme@sandy linux]$ wc -l tools/perf/util/*-{bison,flex}.[ch]
1917 tools/perf/util/parse-events-bison.c
81 tools/perf/util/parse-events-bison.h
1663 tools/perf/util/pmu-bison.c
73 tools/perf/util/pmu-bison.h
2272 tools/perf/util/parse-events-flex.c
316 tools/perf/util/parse-events-flex.h
1821 tools/perf/util/pmu-flex.c
316 tools/perf/util/pmu-flex.h
8459 total
so that we don't require even more tools to build the kernel, following
the precedent of:
[acme@sandy linux]$ wc -l scripts/*/*.[ch]_shipped
1976 scripts/dtc/dtc-lexer.lex.c_shipped
1946 scripts/dtc/dtc-parser.tab.c_shipped
86 scripts/dtc/dtc-parser.tab.h_shipped
220 scripts/genksyms/keywords.hash.c_shipped
2245 scripts/genksyms/lex.lex.c_shipped
2399 scripts/genksyms/parse.tab.c_shipped
95 scripts/genksyms/parse.tab.h_shipped
286 scripts/kconfig/zconf.hash.c_shipped
2420 scripts/kconfig/zconf.lex.c_shipped
2504 scripts/kconfig/zconf.tab.c_shipped
14177 total
[acme@sandy linux]$
But Ingo argues that flex and bison are just a yum/whatever
install away, so we shouldn't clutter the kernel git history with things
we can generate at build time.
What is your take on this?
- Arnaldo
next reply other threads:[~2012-03-27 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 18:15 Arnaldo Carvalho de Melo [this message]
2012-03-27 18:33 ` [RFC] perf tools: Including pre-generated flex files Ingo Molnar
2012-03-29 6:43 ` Jiri Olsa
2012-03-31 7:47 ` [tip:perf/urgent] perf tools: Remove auto-generated bison/ " tip-bot for Ingo Molnar
2012-03-28 19:46 ` [RFC] perf tools: Including pre-generated " Linus Torvalds
2012-03-29 12:22 ` Jiri Olsa
2012-03-29 14:37 ` Arnaldo Carvalho de Melo
2012-03-29 14:38 ` Ingo Molnar
2012-03-29 15:45 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327181547.GA7374@infradead.org \
--to=acme@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox