From: Cyrill Gorcunov <gorcunov@openvz.org>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Serge E. Hallyn" <serge.hallyn@canonical.com>
Subject: Re: [rfc] fcntl: Add F_GETOWNER_UIDS option
Date: Wed, 28 Mar 2012 02:34:20 +0400 [thread overview]
Message-ID: <20120327223420.GB9669@moon> (raw)
In-Reply-To: <20120327222923.GA31692@mail.hallyn.com>
On Tue, Mar 27, 2012 at 10:29:23PM +0000, Serge E. Hallyn wrote:
> Quoting Cyrill Gorcunov (gorcunov@openvz.org):
> > On Tue, Mar 27, 2012 at 05:25:34PM +0200, Oleg Nesterov wrote:
> > > user_ns_map_uid() should translate uid_t from one namespace to another,
> > > in this case the namespace is the same.
> > >
> > > user_ns_map_uid(cred->user_ns, cred) must be the identical mapping,
> > > no matter how we change the implementation.
> > >
> > > What I think you need is
> > > user_ns_map_uid(current_user_ns(), filp->f_owner.cred), the only
> > > problem is that f_owner.cred doesn't exist.
> > >
> >
> > Hmm, I was confused by likely() in user_ns_map_uid. But indeed, I think
> > you're so right. Is there some reason why we can't carry f_owner.cred
> > pointer?
>
> We would need that for this, yes. However, Eric is working on a new
> patchset which changes the cross-userns uid mappings. I think it's
> worth simply leaving a comment that this will need to be addressed,
> and leave in the unconverted uid.
Hi Serge, thanks for info. But if it will be unconverted uid, can't
be there some security problem with that which I missed?
Cyrill
next prev parent reply other threads:[~2012-03-27 22:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 15:09 [rfc] fcntl: Add F_GETOWNER_UIDS option Cyrill Gorcunov
2012-03-26 16:43 ` Oleg Nesterov
2012-03-26 18:33 ` Cyrill Gorcunov
2012-03-27 15:25 ` Oleg Nesterov
2012-03-27 16:58 ` Cyrill Gorcunov
2012-03-27 22:29 ` Serge E. Hallyn
2012-03-27 22:34 ` Cyrill Gorcunov [this message]
2012-03-27 22:46 ` Serge E. Hallyn
2012-03-28 2:22 ` Eric W. Biederman
2012-03-28 6:48 ` Cyrill Gorcunov
[not found] ` <m1k425mae1.fsf@fess.ebiederm.org>
2012-03-28 7:55 ` Cyrill Gorcunov
2012-03-28 8:16 ` Cyrill Gorcunov
2012-03-28 19:43 ` Serge E. Hallyn
2012-03-28 19:46 ` Oleg Nesterov
2012-03-28 21:30 ` Serge Hallyn
2012-03-28 21:32 ` Oleg Nesterov
2012-03-28 21:37 ` Cyrill Gorcunov
2012-03-29 2:30 ` Serge E. Hallyn
2012-03-30 12:31 ` Cyrill Gorcunov
2012-03-30 14:12 ` Serge Hallyn
2012-03-30 14:40 ` Cyrill Gorcunov
2012-03-30 16:15 ` Serge E. Hallyn
2012-03-30 19:46 ` Kees Cook
2012-03-30 19:56 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327223420.GB9669@moon \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox