From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756990Ab2C0WnO (ORCPT ); Tue, 27 Mar 2012 18:43:14 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:38627 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756175Ab2C0WnN (ORCPT ); Tue, 27 Mar 2012 18:43:13 -0400 From: "Rafael J. Wysocki" To: Bojan Smojver Subject: Re: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering Date: Wed, 28 Mar 2012 00:47:33 +0200 User-Agent: KMail/1.13.6 (Linux/3.3.0+; KDE/4.6.0; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, Linux PM mailing list References: <1332887486.2040.10.camel@shrek.rexursive.com> <201203280041.55043.rjw@sisk.pl> <1332887999.2040.13.camel@shrek.rexursive.com> In-Reply-To: <1332887999.2040.13.camel@shrek.rexursive.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201203280047.33501.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, March 28, 2012, Bojan Smojver wrote: > On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote: > > If you define a macro, please use capital letters in the name. Also, > > the parentheses aren't necessary I think. > > > > Perhaps it would be better to use a static inline function instead? > > Hmm, was just following the nr_free_pages() definition in swap.h: > > /* Definition of global_page_state not available yet */ > #define nr_free_pages() global_page_state(NR_FREE_PAGES) > > Still no good? Not really, that should be a static inline too. :-) Thanks, Rafael