From: Andrew Morton <akpm@linux-foundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Anton Vorontsov <anton.vorontsov@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysrq: Use SEND_SIG_FORCED instead of force_sig()
Date: Wed, 28 Mar 2012 14:08:35 -0700 [thread overview]
Message-ID: <20120328140835.38e1f03f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120328205254.GA6930@redhat.com>
On Wed, 28 Mar 2012 22:52:54 +0200
Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/26, Andrew Morton wrote:
> >
> > > --- a/drivers/tty/sysrq.c
> > > +++ b/drivers/tty/sysrq.c
> > > @@ -329,7 +329,7 @@ static void send_sig_all(int sig)
> > > if (is_global_init(p))
> > > continue;
> > >
> > > - force_sig(sig, p);
> > > + do_send_sig_info(sig, SEND_SIG_FORCED, p, true);
> > > }
> > > read_unlock(&tasklist_lock);
> > > }
> >
> > It's unclear how serious this race is (I'm guessing "not very"),
>
> Well yes, I think that the problems are not very serious.
>
> > but
> > this patch looks like 3.3 material anyway, yes?
>
> No, this depends on 629d362b9950166c6fac2aa8425db34d824bb043
> "signal: give SEND_SIG_FORCED more power to beat SIGNAL_UNKILLABLE".
oop, I meant "this patch looks like 3.4 material"?
next prev parent reply other threads:[~2012-03-28 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 11:00 [PATCH] sysrq: Use SEND_SIG_FORCED instead of force_sig() Anton Vorontsov
2012-03-26 22:43 ` Andrew Morton
2012-03-27 13:03 ` Anton Vorontsov
2012-03-28 20:52 ` Oleg Nesterov
2012-03-28 21:08 ` Andrew Morton [this message]
2012-03-28 21:26 ` Oleg Nesterov
[not found] <13288070803232@kroah.org>
[not found] ` <20120210201008.GA21009@redhat.com>
2012-02-14 22:50 ` Anton Vorontsov
2012-02-14 23:03 ` Greg Kroah-Hartman
2012-02-15 13:53 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328140835.38e1f03f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox