From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756131Ab2C1Hqi (ORCPT ); Wed, 28 Mar 2012 03:46:38 -0400 Received: from ch1ehsobe002.messaging.microsoft.com ([216.32.181.182]:17424 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713Ab2C1Hqf (ORCPT ); Wed, 28 Mar 2012 03:46:35 -0400 X-SpamScore: -9 X-BigFish: VPS-9(zz1432N98dKzz1202hzz8275bhz2dh668h839h944hd25h) X-Forefront-Antispam-Report: CIP:163.181.249.109;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp02.amd.com;RD:none;EFVD:NLI X-WSS-ID: 0M1L49F-02-4GS-02 X-M-MSG: Date: Thu, 29 Mar 2012 03:55:16 +0800 From: Aaron Lu To: Lin Ming CC: Zhang Rui , Jeff Garzik , Alan Stern , "Rafael J. Wysocki" , Tejun Heo , , , , , linux-acpi Subject: Re: [PATCH v3 1/7] libata-acpi: set acpi state for SATA port Message-ID: <20120328195509.GA1965@localhost.amd.com> References: <1332915722-15963-1-git-send-email-ming.m.lin@intel.com> <1332915722-15963-2-git-send-email-ming.m.lin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1332915722-15963-2-git-send-email-ming.m.lin@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 28 Mar 2012 07:46:20.0446 (UTC) FILETIME=[DD90FBE0:01CD0CB6] X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, The patch does not apply, are you using libata-devel/ALL branch? -Aaron On Wed, Mar 28, 2012 at 02:21:56PM +0800, Lin Ming wrote: > Currently, ata_acpi_set_state() only sets acpi sate for IDE port. > Remove this limitation. > > Acked-by: Aaron Lu > Signed-off-by: Lin Ming > --- > drivers/ata/libata-acpi.c | 21 ++++++++++++--------- > 1 files changed, 12 insertions(+), 9 deletions(-) > > diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c > index b03e468..104c1d0 100644 > --- a/drivers/ata/libata-acpi.c > +++ b/drivers/ata/libata-acpi.c > @@ -841,23 +841,26 @@ void ata_acpi_on_resume(struct ata_port *ap) > void ata_acpi_set_state(struct ata_port *ap, pm_message_t state) > { > struct ata_device *dev; > - > - if (!ata_ap_acpi_handle(ap) || (ap->flags & ATA_FLAG_ACPI_SATA)) > - return; > + acpi_handle handle; > + int acpi_state; > > /* channel first and then drives for power on and vica versa > for power off */ > - if (state.event == PM_EVENT_ON) > - acpi_bus_set_power(ata_ap_acpi_handle(ap), ACPI_STATE_D0); > + handle = ata_ap_acpi_handle(ap); > + if (handle && state.event == PM_EVENT_ON) > + acpi_bus_set_power(handle, ACPI_STATE_D0); > > ata_for_each_dev(dev, &ap->link, ENABLED) { > - if (ata_dev_acpi_handle(dev)) > - acpi_bus_set_power(ata_dev_acpi_handle(dev), > + handle = ata_dev_acpi_handle(dev); > + if (handle) > + acpi_bus_set_power(handle, > state.event == PM_EVENT_ON ? > ACPI_STATE_D0 : ACPI_STATE_D3); > } > - if (state.event != PM_EVENT_ON) > - acpi_bus_set_power(ata_ap_acpi_handle(ap), ACPI_STATE_D3); > + > + handle = ata_ap_acpi_handle(ap); > + if (handle && state.event != PM_EVENT_ON) > + acpi_bus_set_power(handle, ACPI_STATE_D3); > } > > /** > -- > 1.7.2.5 > >