From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: David Howells <dhowells@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: On patch "Remove all #inclusions of asm/system.h"
Date: Thu, 29 Mar 2012 15:34:09 +0200 [thread overview]
Message-ID: <20120329153409.7295eda9@stein> (raw)
Hi David,
commit 9ffc93f2 "Remove all #inclusions of asm/system.h" removes a lot of
includes while its parent commit 96f951ed "Add #includes needed to permit
the removal of asm/system.h" adds only a few. Some of the files modified
by commit 9ffc93f2 now only work due to indirect inclusion, don't they?
For example, drivers/firewire/{core-device,core-topology,ohci,sbp2}.c use
smp_rmb()¹ and used to include asm/system.h. Now they do not include
asm/barrier.h. Is this by mistake or on purpose?
(I only noticed the commit come in; I did not get any build error yet.
The mentioned files now get asm/barrier.h via linux/spinlock.h and
certainly via other ways as well.)
--------
¹) so does drivers/firewire/net.c but it missed to include asm/system.h
--
Stefan Richter
-=====-===-- --== ===-=
http://arcgraph.de/sr/
next reply other threads:[~2012-03-29 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 13:34 Stefan Richter [this message]
2012-03-31 19:31 ` On patch "Remove all #inclusions of asm/system.h" David Howells
2012-03-31 20:44 ` Stefan Richter
2012-04-01 1:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329153409.7295eda9@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox