public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: John Kacur <jkacur@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Remove a superfluous check
Date: Thu, 29 Mar 2012 19:26:19 +0200	[thread overview]
Message-ID: <20120329172618.GF6409@aftab> (raw)
In-Reply-To: <alpine.LFD.2.02.1203291914040.10113@tycho>

On Thu, Mar 29, 2012 at 07:17:19PM +0200, John Kacur wrote:

> It looks okay to me. Technically it's not functionally equivalent
> though, because now when __register_ftrace_function is called
> directly, (in other paths), the test has an unlikely there.

I know, but ftrace_disabled is really unlikely to be set to 1 because
we set it only if ftrace_init() fails and on the panic path in
ftrace_kill().

So I agree that it is not functionally completely equivalent but it
should be correct with the unlikely.

> See what teven says, otherwise, you can have my reviewed by.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

  parent reply	other threads:[~2012-03-29 17:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 16:44 [PATCH] ftrace: Remove a superfluous check Borislav Petkov
2012-03-29 17:03 ` John Kacur
2012-03-29 17:11   ` Borislav Petkov
2012-03-29 17:17     ` John Kacur
2012-03-29 17:23       ` Steven Rostedt
2012-03-29 17:26       ` Borislav Petkov [this message]
2012-05-24 16:32     ` Borislav Petkov
2012-05-24 16:41       ` Steven Rostedt
2012-05-24 17:04         ` Borislav Petkov
2012-06-20 10:38     ` [tip:perf/core] " tip-bot for Borislav Petkov
2012-03-29 17:14   ` [PATCH] " Steven Rostedt
2012-03-29 17:27     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120329172618.GF6409@aftab \
    --to=bp@amd64.org \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox