Re: [PATCH v2] tty: hold lock across tty buffer finding and buffer filling

Alan Cox
2012-03-30T10:31:54Z

On Fri, 30 Mar 2012 10:26:27 +0000
"Tu, Xiaobing" <xiaobing.tu@intel.com> wrote:

> Hi Greg
> Even there still a prepare buffer not protected, the patch is still good to protect rest case, so this patch is still "nice to have"
> it makes the situation better. for the not-fixed case, we can have another patch to address that. Do you agree?

Can't speak for Greg (who I suspect is busy with the merge window to
Linus) but I think this is the right thing to do once the merge window is
over. The unfixed case needs other things to happen first, such as the
removal of tty_lock/tty_unlock. At that point much of this should become
much simpler.

Alan