From: Greg Kroah-Hartman <greg@kroah.com>
To: Phillip Lougher <phil.lougher@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Weinberger <richard@nod.at>,
Phillip Lougher <plougher@redhat.com>,
linux-kernel@vger.kernel.org,
Dan Rosenberg <drosenberg@vsecurity.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Eugene Teo <eteo@redhat.com>, Eric Paris <eparis@redhat.com>,
James Morris <jmorris@namei.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] sysctl: fix restrict write access to dmesg_restrict
Date: Sat, 31 Mar 2012 09:13:39 -0700 [thread overview]
Message-ID: <20120331161339.GK27849@kroah.com> (raw)
In-Reply-To: <CA+2-8GAg6x04FyZwNnBbQDhpL5Stwy+s4yZmMYRX8ZCUVjYsvQ@mail.gmail.com>
On Sat, Mar 31, 2012 at 02:58:02AM +0100, Phillip Lougher wrote:
> On Sat, Mar 31, 2012 at 1:55 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >
> > Presumably someone else fiddled with the file, patch(1) misapplied the
> > hunk and I didn't notice.
> >
>
> That was my guess, the repeated near identical sysfs entries is
> confusing patch. The stable kernels also suffer from this
> misapplication, but the misapplication is random, for instance I
> noticed here
>
> http://www.mail-archive.com/stable@linux.kernel.org/msg07097.html
>
> that the patch has been misapplied to suid_dumpable. It looks like
> all of the stable kernels need to be separately checked, and if
> necessary different patches need to be generated.
Ok, can someone please do this and send me the patches? I don't exactly
know what you are referring to here to be able to do it myself...
greg k-h
next prev parent reply other threads:[~2012-03-31 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 23:43 [PATCH] sysctl: fix restrict write access to dmesg_restrict Phillip Lougher
2012-03-30 23:50 ` Richard Weinberger
2012-03-31 0:55 ` Andrew Morton
2012-03-31 1:58 ` Phillip Lougher
2012-03-31 16:13 ` Greg Kroah-Hartman [this message]
2012-04-01 2:10 ` Kees Cook
2012-04-04 2:30 ` Serge E. Hallyn
2012-04-04 18:40 ` [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict Kees Cook
2012-04-04 19:07 ` Richard Weinberger
2012-04-04 21:27 ` Serge E. Hallyn
2012-04-04 21:43 ` Kees Cook
2012-04-05 5:11 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331161339.GK27849@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=drosenberg@vsecurity.com \
--cc=eparis@redhat.com \
--cc=eteo@redhat.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.lougher@gmail.com \
--cc=plougher@redhat.com \
--cc=richard@nod.at \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox