public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
@ 2012-03-31 21:22 Sasha Levin
  2012-04-01  2:17 ` Yong Zhang
  2012-04-01 17:36 ` Thomas Gleixner
  0 siblings, 2 replies; 8+ messages in thread
From: Sasha Levin @ 2012-03-31 21:22 UTC (permalink / raw)
  To: tglx; +Cc: linux-kernel, Sasha Levin

During the init stage, we have only 1 cpu and run with IRQs disabled,
we can't allocate with GFP_KERNEL.

This also fixes the related warning on boot.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 lib/debugobjects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 0ab9ae8..ece5e06 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1020,7 +1020,7 @@ static int __init debug_objects_replace_static_objects(void)
 	int i, cnt = 0;
 
 	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
-		obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
+		obj = kmem_cache_zalloc(obj_cache, GFP_ATOMIC);
 		if (!obj)
 			goto free;
 		hlist_add_head(&obj->node, &objects);
-- 
1.7.8.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-03-31 21:22 [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing Sasha Levin
@ 2012-04-01  2:17 ` Yong Zhang
  2012-04-01 17:36 ` Thomas Gleixner
  1 sibling, 0 replies; 8+ messages in thread
From: Yong Zhang @ 2012-04-01  2:17 UTC (permalink / raw)
  To: Sasha Levin; +Cc: tglx, linux-kernel

On Sat, Mar 31, 2012 at 05:22:52PM -0400, Sasha Levin wrote:
> During the init stage, we have only 1 cpu and run with IRQs disabled,

debug_objects_mem_init() is called after local_irq_enable() in
start_kernel()

> we can't allocate with GFP_KERNEL.
> 
> This also fixes the related warning on boot.

Not sure how you get that.

Thanks,
Yong


> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  lib/debugobjects.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index 0ab9ae8..ece5e06 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -1020,7 +1020,7 @@ static int __init debug_objects_replace_static_objects(void)
>  	int i, cnt = 0;
>  
>  	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
> -		obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
> +		obj = kmem_cache_zalloc(obj_cache, GFP_ATOMIC);
>  		if (!obj)
>  			goto free;
>  		hlist_add_head(&obj->node, &objects);
> -- 
> 1.7.8.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Only stand for myself

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-03-31 21:22 [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing Sasha Levin
  2012-04-01  2:17 ` Yong Zhang
@ 2012-04-01 17:36 ` Thomas Gleixner
  2012-04-01 17:53   ` Sasha Levin
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Gleixner @ 2012-04-01 17:36 UTC (permalink / raw)
  To: Sasha Levin; +Cc: linux-kernel

On Sat, 31 Mar 2012, Sasha Levin wrote:

> During the init stage, we have only 1 cpu and run with IRQs disabled,
> we can't allocate with GFP_KERNEL.
> 
> This also fixes the related warning on boot.

Hrmm. This should not be the case. In early boot GFP_KERNEL
allocations should not trigger a warning when interrupts are
disabled. Which kind of warning are you observing ?

Thanks,

	tglx

 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  lib/debugobjects.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index 0ab9ae8..ece5e06 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -1020,7 +1020,7 @@ static int __init debug_objects_replace_static_objects(void)
>  	int i, cnt = 0;
>  
>  	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
> -		obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
> +		obj = kmem_cache_zalloc(obj_cache, GFP_ATOMIC);
>  		if (!obj)
>  			goto free;
>  		hlist_add_head(&obj->node, &objects);
> -- 
> 1.7.8.5
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-04-01 17:36 ` Thomas Gleixner
@ 2012-04-01 17:53   ` Sasha Levin
  2012-04-02  9:12     ` Thomas Gleixner
  0 siblings, 1 reply; 8+ messages in thread
From: Sasha Levin @ 2012-04-01 17:53 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-kernel

On Sun, Apr 1, 2012 at 7:36 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sat, 31 Mar 2012, Sasha Levin wrote:
>
>> During the init stage, we have only 1 cpu and run with IRQs disabled,
>> we can't allocate with GFP_KERNEL.
>>
>> This also fixes the related warning on boot.
>
> Hrmm. This should not be the case. In early boot GFP_KERNEL
> allocations should not trigger a warning when interrupts are
> disabled. Which kind of warning are you observing ?

There were two, both pointing at the same WARN(). I don't have the
first one which was fixed in this patch handy, but the second one is:

[    0.000000] WARNING: at kernel/lockdep.c:2739
lockdep_trace_alloc+0x11f/0x130()
[    0.000000] Pid: 0, comm: swapper/0 Not tainted
3.3.0-next-20120330-sasha-dirty #40
[    0.000000] Call Trace:
[    0.000000]  [<ffffffff810b4175>] warn_slowpath_common+0x75/0xb0
[    0.000000]  [<ffffffff810b41c5>] warn_slowpath_null+0x15/0x20
[    0.000000]  [<ffffffff8111999f>] lockdep_trace_alloc+0x11f/0x130
[    0.000000]  [<ffffffff81182e0c>] __alloc_pages_nodemask+0x9c/0x260
[    0.000000]  [<ffffffff826bcea7>] ? retint_restore_args+0x6/0x13
[    0.000000]  [<ffffffff811cc2cd>] kmemcheck_alloc_shadow+0x4d/0xf0
[    0.000000]  [<ffffffff811c5597>] allocate_slab+0x197/0x270
[    0.000000]  [<ffffffff811c569b>] new_slab+0x2b/0x190
[    0.000000]  [<ffffffff811c7e7a>] ? __slab_alloc+0x5a/0x6b0
[    0.000000]  [<ffffffff811c82b3>] __slab_alloc+0x493/0x6b0
[    0.000000]  [<ffffffff81114f61>] ? trace_hardirqs_off_caller+0xe1/0x150
[    0.000000]  [<ffffffff81886f1d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
[    0.000000]  [<ffffffff8395eb55>] ?
debug_objects_replace_static_objects+0x2a/0x1f5
[    0.000000]  [<ffffffff8395eb55>] ?
debug_objects_replace_static_objects+0x2a/0x1f5
[    0.000000]  [<ffffffff811c900e>] kmem_cache_alloc+0x17e/0x1a0
[    0.000000]  [<ffffffff8395eb55>]
debug_objects_replace_static_objects+0x2a/0x1f5
[    0.000000]  [<ffffffff8395ed59>] debug_objects_mem_init+0x39/0x68
[    0.000000]  [<ffffffff8392af65>] start_kernel+0x33a/0x3f8
[    0.000000]  [<ffffffff8392aa13>] ? kernel_init+0x280/0x280
[    0.000000]  [<ffffffff8392a2b6>] x86_64_start_reservations+0xa1/0xa6
[    0.000000]  [<ffffffff8392a410>] x86_64_start_kernel+0x155/0x164
[    0.000000] ---[ end trace a7919e7f17c0a725 ]---

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-04-01 17:53   ` Sasha Levin
@ 2012-04-02  9:12     ` Thomas Gleixner
  2012-04-02 18:35       ` Peter Zijlstra
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Gleixner @ 2012-04-02  9:12 UTC (permalink / raw)
  To: Sasha Levin; +Cc: LKML, Peter Zijlstra

On Sun, 1 Apr 2012, Sasha Levin wrote:
> On Sun, Apr 1, 2012 at 7:36 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Sat, 31 Mar 2012, Sasha Levin wrote:

Peter ????

> >> During the init stage, we have only 1 cpu and run with IRQs disabled,
> >> we can't allocate with GFP_KERNEL.
> >>
> >> This also fixes the related warning on boot.
> >
> > Hrmm. This should not be the case. In early boot GFP_KERNEL
> > allocations should not trigger a warning when interrupts are
> > disabled. Which kind of warning are you observing ?
> 
> There were two, both pointing at the same WARN(). I don't have the
> first one which was fixed in this patch handy, but the second one is:
> 
> [    0.000000] WARNING: at kernel/lockdep.c:2739
> lockdep_trace_alloc+0x11f/0x130()
> [    0.000000] Pid: 0, comm: swapper/0 Not tainted
> 3.3.0-next-20120330-sasha-dirty #40
> [    0.000000] Call Trace:
> [    0.000000]  [<ffffffff810b4175>] warn_slowpath_common+0x75/0xb0
> [    0.000000]  [<ffffffff810b41c5>] warn_slowpath_null+0x15/0x20
> [    0.000000]  [<ffffffff8111999f>] lockdep_trace_alloc+0x11f/0x130
> [    0.000000]  [<ffffffff81182e0c>] __alloc_pages_nodemask+0x9c/0x260
> [    0.000000]  [<ffffffff826bcea7>] ? retint_restore_args+0x6/0x13
> [    0.000000]  [<ffffffff811cc2cd>] kmemcheck_alloc_shadow+0x4d/0xf0
> [    0.000000]  [<ffffffff811c5597>] allocate_slab+0x197/0x270
> [    0.000000]  [<ffffffff811c569b>] new_slab+0x2b/0x190
> [    0.000000]  [<ffffffff811c7e7a>] ? __slab_alloc+0x5a/0x6b0
> [    0.000000]  [<ffffffff811c82b3>] __slab_alloc+0x493/0x6b0
> [    0.000000]  [<ffffffff81114f61>] ? trace_hardirqs_off_caller+0xe1/0x150
> [    0.000000]  [<ffffffff81886f1d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
> [    0.000000]  [<ffffffff8395eb55>] ?
> debug_objects_replace_static_objects+0x2a/0x1f5
> [    0.000000]  [<ffffffff8395eb55>] ?
> debug_objects_replace_static_objects+0x2a/0x1f5
> [    0.000000]  [<ffffffff811c900e>] kmem_cache_alloc+0x17e/0x1a0
> [    0.000000]  [<ffffffff8395eb55>]
> debug_objects_replace_static_objects+0x2a/0x1f5
> [    0.000000]  [<ffffffff8395ed59>] debug_objects_mem_init+0x39/0x68
> [    0.000000]  [<ffffffff8392af65>] start_kernel+0x33a/0x3f8
> [    0.000000]  [<ffffffff8392aa13>] ? kernel_init+0x280/0x280
> [    0.000000]  [<ffffffff8392a2b6>] x86_64_start_reservations+0xa1/0xa6
> [    0.000000]  [<ffffffff8392a410>] x86_64_start_kernel+0x155/0x164
> [    0.000000] ---[ end trace a7919e7f17c0a725 ]---

 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-04-02  9:12     ` Thomas Gleixner
@ 2012-04-02 18:35       ` Peter Zijlstra
  2012-04-02 18:38         ` Pekka Enberg
  2012-04-02 19:05         ` Sasha Levin
  0 siblings, 2 replies; 8+ messages in thread
From: Peter Zijlstra @ 2012-04-02 18:35 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Sasha Levin, LKML

On Mon, 2012-04-02 at 11:12 +0200, Thomas Gleixner wrote:
> On Sun, 1 Apr 2012, Sasha Levin wrote:
> > On Sun, Apr 1, 2012 at 7:36 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > On Sat, 31 Mar 2012, Sasha Levin wrote:
> 
> Peter ????
> 
> > >> During the init stage, we have only 1 cpu and run with IRQs disabled,
> > >> we can't allocate with GFP_KERNEL.
> > >>
> > >> This also fixes the related warning on boot.
> > >
> > > Hrmm. This should not be the case. In early boot GFP_KERNEL
> > > allocations should not trigger a warning when interrupts are
> > > disabled. Which kind of warning are you observing ?
> > 
> > There were two, both pointing at the same WARN(). I don't have the
> > first one which was fixed in this patch handy, but the second one is:
> > 
> > [    0.000000] WARNING: at kernel/lockdep.c:2739
> > lockdep_trace_alloc+0x11f/0x130()
> > [    0.000000] Pid: 0, comm: swapper/0 Not tainted
> > 3.3.0-next-20120330-sasha-dirty #40
> > [    0.000000] Call Trace:
> > [    0.000000]  [<ffffffff810b4175>] warn_slowpath_common+0x75/0xb0
> > [    0.000000]  [<ffffffff810b41c5>] warn_slowpath_null+0x15/0x20
> > [    0.000000]  [<ffffffff8111999f>] lockdep_trace_alloc+0x11f/0x130
> > [    0.000000]  [<ffffffff81182e0c>] __alloc_pages_nodemask+0x9c/0x260
> > [    0.000000]  [<ffffffff826bcea7>] ? retint_restore_args+0x6/0x13
> > [    0.000000]  [<ffffffff811cc2cd>] kmemcheck_alloc_shadow+0x4d/0xf0
> > [    0.000000]  [<ffffffff811c5597>] allocate_slab+0x197/0x270
> > [    0.000000]  [<ffffffff811c569b>] new_slab+0x2b/0x190
> > [    0.000000]  [<ffffffff811c7e7a>] ? __slab_alloc+0x5a/0x6b0
> > [    0.000000]  [<ffffffff811c82b3>] __slab_alloc+0x493/0x6b0
> > [    0.000000]  [<ffffffff81114f61>] ? trace_hardirqs_off_caller+0xe1/0x150
> > [    0.000000]  [<ffffffff81886f1d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
> > [    0.000000]  [<ffffffff8395eb55>] ?
> > debug_objects_replace_static_objects+0x2a/0x1f5
> > [    0.000000]  [<ffffffff8395eb55>] ?
> > debug_objects_replace_static_objects+0x2a/0x1f5
> > [    0.000000]  [<ffffffff811c900e>] kmem_cache_alloc+0x17e/0x1a0
> > [    0.000000]  [<ffffffff8395eb55>]
> > debug_objects_replace_static_objects+0x2a/0x1f5
> > [    0.000000]  [<ffffffff8395ed59>] debug_objects_mem_init+0x39/0x68
> > [    0.000000]  [<ffffffff8392af65>] start_kernel+0x33a/0x3f8
> > [    0.000000]  [<ffffffff8392aa13>] ? kernel_init+0x280/0x280
> > [    0.000000]  [<ffffffff8392a2b6>] x86_64_start_reservations+0xa1/0xa6
> > [    0.000000]  [<ffffffff8392a410>] x86_64_start_kernel+0x155/0x164
> > [    0.000000] ---[ end trace a7919e7f17c0a725 ]---
> 
>  

Something like so?

---
 kernel/lockdep.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index ea9ee45..a028ba9 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2718,6 +2718,13 @@ static void __lockdep_trace_alloc(gfp_t gfp_mask, unsigned long flags)
 {
 	struct task_struct *curr = current;
 
+	/*
+	 * We do GFP_KERNEL allocations with IRQs disabled during system
+	 * bringup..
+	 */
+	if (unlikely(system_state != SYSTEM_RUNNING))
+		return;
+
 	if (unlikely(!debug_locks))
 		return;
 



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-04-02 18:35       ` Peter Zijlstra
@ 2012-04-02 18:38         ` Pekka Enberg
  2012-04-02 19:05         ` Sasha Levin
  1 sibling, 0 replies; 8+ messages in thread
From: Pekka Enberg @ 2012-04-02 18:38 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: Thomas Gleixner, Sasha Levin, LKML

On Mon, Apr 2, 2012 at 9:35 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> Something like so?
>
> ---
>  kernel/lockdep.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> index ea9ee45..a028ba9 100644
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -2718,6 +2718,13 @@ static void __lockdep_trace_alloc(gfp_t gfp_mask, unsigned long flags)
>  {
>        struct task_struct *curr = current;
>
> +       /*
> +        * We do GFP_KERNEL allocations with IRQs disabled during system
> +        * bringup..
> +        */
> +       if (unlikely(system_state != SYSTEM_RUNNING))
> +               return;
> +
>        if (unlikely(!debug_locks))
>                return;

Yes, please.

Acked-by: Pekka Enberg <penberg@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
  2012-04-02 18:35       ` Peter Zijlstra
  2012-04-02 18:38         ` Pekka Enberg
@ 2012-04-02 19:05         ` Sasha Levin
  1 sibling, 0 replies; 8+ messages in thread
From: Sasha Levin @ 2012-04-02 19:05 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: Thomas Gleixner, LKML

On Mon, Apr 2, 2012 at 8:35 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2012-04-02 at 11:12 +0200, Thomas Gleixner wrote:
>> On Sun, 1 Apr 2012, Sasha Levin wrote:
>> > On Sun, Apr 1, 2012 at 7:36 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> > > On Sat, 31 Mar 2012, Sasha Levin wrote:
>>
>> Peter ????
>>
>> > >> During the init stage, we have only 1 cpu and run with IRQs disabled,
>> > >> we can't allocate with GFP_KERNEL.
>> > >>
>> > >> This also fixes the related warning on boot.
>> > >
>> > > Hrmm. This should not be the case. In early boot GFP_KERNEL
>> > > allocations should not trigger a warning when interrupts are
>> > > disabled. Which kind of warning are you observing ?
>> >
>> > There were two, both pointing at the same WARN(). I don't have the
>> > first one which was fixed in this patch handy, but the second one is:
>> >
>> > [    0.000000] WARNING: at kernel/lockdep.c:2739
>> > lockdep_trace_alloc+0x11f/0x130()
>> > [    0.000000] Pid: 0, comm: swapper/0 Not tainted
>> > 3.3.0-next-20120330-sasha-dirty #40
>> > [    0.000000] Call Trace:
>> > [    0.000000]  [<ffffffff810b4175>] warn_slowpath_common+0x75/0xb0
>> > [    0.000000]  [<ffffffff810b41c5>] warn_slowpath_null+0x15/0x20
>> > [    0.000000]  [<ffffffff8111999f>] lockdep_trace_alloc+0x11f/0x130
>> > [    0.000000]  [<ffffffff81182e0c>] __alloc_pages_nodemask+0x9c/0x260
>> > [    0.000000]  [<ffffffff826bcea7>] ? retint_restore_args+0x6/0x13
>> > [    0.000000]  [<ffffffff811cc2cd>] kmemcheck_alloc_shadow+0x4d/0xf0
>> > [    0.000000]  [<ffffffff811c5597>] allocate_slab+0x197/0x270
>> > [    0.000000]  [<ffffffff811c569b>] new_slab+0x2b/0x190
>> > [    0.000000]  [<ffffffff811c7e7a>] ? __slab_alloc+0x5a/0x6b0
>> > [    0.000000]  [<ffffffff811c82b3>] __slab_alloc+0x493/0x6b0
>> > [    0.000000]  [<ffffffff81114f61>] ? trace_hardirqs_off_caller+0xe1/0x150
>> > [    0.000000]  [<ffffffff81886f1d>] ? trace_hardirqs_off_thunk+0x3a/0x3c
>> > [    0.000000]  [<ffffffff8395eb55>] ?
>> > debug_objects_replace_static_objects+0x2a/0x1f5
>> > [    0.000000]  [<ffffffff8395eb55>] ?
>> > debug_objects_replace_static_objects+0x2a/0x1f5
>> > [    0.000000]  [<ffffffff811c900e>] kmem_cache_alloc+0x17e/0x1a0
>> > [    0.000000]  [<ffffffff8395eb55>]
>> > debug_objects_replace_static_objects+0x2a/0x1f5
>> > [    0.000000]  [<ffffffff8395ed59>] debug_objects_mem_init+0x39/0x68
>> > [    0.000000]  [<ffffffff8392af65>] start_kernel+0x33a/0x3f8
>> > [    0.000000]  [<ffffffff8392aa13>] ? kernel_init+0x280/0x280
>> > [    0.000000]  [<ffffffff8392a2b6>] x86_64_start_reservations+0xa1/0xa6
>> > [    0.000000]  [<ffffffff8392a410>] x86_64_start_kernel+0x155/0x164
>> > [    0.000000] ---[ end trace a7919e7f17c0a725 ]---
>>
>>
>
> Something like so?
>
> ---
>  kernel/lockdep.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> index ea9ee45..a028ba9 100644
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -2718,6 +2718,13 @@ static void __lockdep_trace_alloc(gfp_t gfp_mask, unsigned long flags)
>  {
>        struct task_struct *curr = current;
>
> +       /*
> +        * We do GFP_KERNEL allocations with IRQs disabled during system
> +        * bringup..
> +        */
> +       if (unlikely(system_state != SYSTEM_RUNNING))
> +               return;
> +
>        if (unlikely(!debug_locks))
>                return;

Does the trick here.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-04-02 19:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-31 21:22 [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing Sasha Levin
2012-04-01  2:17 ` Yong Zhang
2012-04-01 17:36 ` Thomas Gleixner
2012-04-01 17:53   ` Sasha Levin
2012-04-02  9:12     ` Thomas Gleixner
2012-04-02 18:35       ` Peter Zijlstra
2012-04-02 18:38         ` Pekka Enberg
2012-04-02 19:05         ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox