From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: Linux 3.4-rc1
Date: Sun, 1 Apr 2012 10:34:06 +0200 [thread overview]
Message-ID: <20120401083406.GA21108@gmail.com> (raw)
In-Reply-To: <CA+55aFy4aFGRLUrF+rYN3dskTepBtC+=x3B3bc_rzf1OaN_5pw@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> [...]
>
> One thing worth pointing out is that the header file cleanups
> were nice, but let's never do them again. Or at least not for
> a release or two. They caused a lot of merge conflicts and
> small annoyances, and while I'm ok with resolving merges, it
> was annoying enough that I don't want to go through that
> immediately again. I know they also annoyed some
> submaintainers that were complaining to me about the pain.
I wasn't amongst those complaining and I agree with the system.h
elimination cleanup, but I think it's better to do these right
at -rc1 time instead of during -rc0 ...
There's very little complex testing needed: only build coverage
on architectures and key configs - one iteration of linux-next
exposure will do that.
So acks can be gathered, it can be rebased to -rc1 or almost-rc1
and can be pulled in (or conflict-merged), before folks grow a
large development tree again.
> That said, I do think they helped. The <asm/system.h>
> disintegration (and to a smaller degree the bug.h cleanups)
> may have been painful, but it definitely cleaned things up.
> [...]
Agreed. We probably need a similar sched.h, fs.h and mm.h
splitting/elimination/shrinking pass as well :-)
> [...] So I guess we *will* do things like this in the future
> again, I just want to forget about the pain before we embark
> on this next time. Ok?
I think this kind of pain is largely avoidable via proper timing
- this one simply wasn't timed properly - pulling it in in the
middle of the merge window was rather crazy and I think you
regretted it on the next morning! ;-)
Thanks,
Ingo
next prev parent reply other threads:[~2012-04-01 8:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 23:58 Linux 3.4-rc1 Linus Torvalds
2012-04-01 0:09 ` Christoph Hellwig
2012-04-01 1:46 ` Shea Levy
2012-04-01 3:11 ` Linus Torvalds
2012-04-01 1:48 ` Shea Levy
2012-04-01 2:07 ` Shea Levy
2012-04-01 8:34 ` Ingo Molnar [this message]
2012-04-01 12:03 ` Stephen Rothwell
2012-04-01 19:19 ` David Miller
2012-04-01 13:14 ` linux-next stats (Was: Linux 3.4-rc1) Stephen Rothwell
2012-04-01 15:34 ` Linux 3.4-rc1 Rob Clark
2012-04-02 3:40 ` Kyungmin Park
2012-04-02 8:41 ` Daniel Vetter
2012-04-04 12:24 ` Subash Patel
2012-04-04 12:33 ` Anca Emanuel
2012-04-05 7:41 ` Marek Szyprowski
2012-04-02 12:31 ` Alex Deucher
2012-04-02 9:15 ` Artem Bityutskiy
2012-04-02 9:20 ` Shubhrajyoti Datta
2012-04-02 15:48 ` Linus Walleij
2012-04-02 20:30 ` Carlos Chinea
2012-04-03 2:57 ` Kyungmin Park
2012-04-03 3:57 ` Linus Torvalds
2012-04-03 6:29 ` Hiroshi Doyu
2012-04-03 9:07 ` Arnd Bergmann
2012-04-03 14:58 ` Jerome Glisse
2012-04-03 15:35 ` Arnd Bergmann
2012-04-03 19:26 ` Krishna Reddy
2012-04-04 12:10 ` Anca Emanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401083406.GA21108@gmail.com \
--to=mingo@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).