From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Denys Vlasenko <vda.linux@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Extend core dump note section to contain file names of mapped files
Date: Sun, 1 Apr 2012 11:44:25 +0200 [thread overview]
Message-ID: <20120401094425.GQ17822@one.firstfloor.org> (raw)
In-Reply-To: <4F77C972.2000200@zytor.com>
On Sat, Mar 31, 2012 at 08:20:18PM -0700, H. Peter Anvin wrote:
> On 03/31/2012 08:13 PM, Andi Kleen wrote:
> >> I propose to save this information in core dump, as a new note
> >> in note segment.
> >
> > Seems like a good idea but rather than write complicated code i would just reuse
> > the /proc/*/maps code and dump it in that format?
> >
>
> Does /proc/*/maps handle oddball characters in filenames?
It doesn't handle new lines well, but then if someone does that they
break all programs that parse maps for other reasons (and likely
a lot of other things too) anyways.
Other than that it should be ok: the file name is just the last component
on the line.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-04-01 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 20:51 [PATCH] Extend core dump note section to contain file names of mapped files Denys Vlasenko
2012-04-01 3:13 ` Andi Kleen
2012-04-01 3:20 ` H. Peter Anvin
2012-04-01 9:44 ` Andi Kleen [this message]
2012-04-01 13:33 ` Denys Vlasenko
2012-04-01 16:53 ` Andi Kleen
2012-04-02 0:24 ` Oleg Nesterov
2012-04-02 11:20 ` Pedro Alves
-- strict thread matches above, loose matches on Subject: below --
2012-07-11 10:35 Denys Vlasenko
2012-07-11 15:15 ` Oleg Nesterov
2012-07-12 19:41 ` Denys Vlasenko
2012-07-11 15:40 ` Jonathan M. Foote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401094425.GQ17822@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox