From: Aaron Lu <aaron.lu@amd.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.org>, "Rafeal J. Wysocki" <rjw@sisk.pl>,
<linux-acpi@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Andiry Xu <andiry.xu@amd.com>, Alex He <alex.he@amd.com>
Subject: Re: [PATCH] ACPI: evaluate _PS3 when entering D3 Cold
Date: Sun, 1 Apr 2012 22:41:25 +0800 [thread overview]
Message-ID: <20120401144125.GA2900@localhost.amd.com> (raw)
In-Reply-To: <1333261737.2939.84.camel@minggr>
On Sun, Apr 01, 2012 at 02:28:57PM +0800, Lin Ming wrote:
> >
> > There is no D3 hot support for this device(from the firmware's
> > perspective), either it is at D0(via _PS0), or it will be at D3 cold(via
> > _PS3).
>
> But this is the generic code. We can't only consider some special
> device.
Agree.
The code change I've made only affects D3 cold path, existing code path
to set device power state to D0-D3hot is not affected.
And for D3 cold path, I don't think evaluating _PS3 should do any harm
to the device, isn't it the case?
>
> Maybe we need some flag to tell which D3 state _PS3 is used for.
Do you mean the ACPI spec needs to be updated to reflect which D3
state the device will be at once its _PS3 is evaluated?
-Aaron
next prev parent reply other threads:[~2012-04-01 6:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 18:18 [PATCH] ACPI: evaluate _PS3 when entering D3 Cold Aaron Lu
2012-04-01 5:27 ` Lin Ming
2012-04-01 5:56 ` Aaron Lu
2012-04-01 6:28 ` Lin Ming
2012-04-01 7:23 ` Rafael J. Wysocki
2012-04-01 7:45 ` Zhang Rui
2012-04-01 8:49 ` Rafael J. Wysocki
2012-04-05 3:20 ` huang ying
2012-04-08 23:41 ` Rafael J. Wysocki
2012-04-09 2:24 ` Huang Ying
2012-04-09 21:24 ` Rafael J. Wysocki
2012-04-05 2:31 ` Lin Ming
2012-04-05 2:56 ` Aaron Lu
2012-04-05 3:01 ` Lin Ming
2012-04-08 23:54 ` Rafael J. Wysocki
2012-04-09 1:38 ` Lin Ming
2012-04-09 21:25 ` Rafael J. Wysocki
2012-04-08 23:53 ` Rafael J. Wysocki
2012-04-08 23:47 ` Rafael J. Wysocki
2012-04-05 2:38 ` Lin Ming
2012-04-09 0:02 ` Rafael J. Wysocki
2012-04-01 14:41 ` Aaron Lu [this message]
2012-04-01 7:03 ` Zhang Rui
2012-04-01 7:29 ` Rafael J. Wysocki
2012-04-01 15:34 ` Aaron Lu
2012-04-01 7:47 ` Rafael J. Wysocki
2012-04-01 8:01 ` Zhang Rui
2012-04-01 8:55 ` Rafael J. Wysocki
2012-04-23 1:09 ` Aaron Lu
2012-04-23 11:43 ` Rafael J. Wysocki
2012-04-23 15:13 ` Aaron Lu
2012-04-23 19:50 ` Rafael J. Wysocki
2012-04-24 2:07 ` Aaron Lu
2012-04-24 2:29 ` Lin Ming
2012-04-24 3:10 ` Aaron Lu
2012-04-24 13:15 ` Lin Ming
2012-04-24 14:24 ` Aaron Lu
2012-04-24 21:15 ` Rafael J. Wysocki
2012-04-26 8:55 ` huang ying
2012-04-26 20:04 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401144125.GA2900@localhost.amd.com \
--to=aaron.lu@amd.com \
--cc=alex.he@amd.com \
--cc=andiry.xu@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox