From: Masami Hiramatsu <masami.hiramatsu@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Huang Ying <ying.huang@intel.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [RFC PATCH -tip 05/16] x86: Disassemble x86-64 only instructions
Date: Mon, 02 Apr 2012 01:03:15 +0900 [thread overview]
Message-ID: <20120401160315.4502.55715.stgit@shimauta> (raw)
In-Reply-To: <20120401160229.4502.2541.stgit@shimauta>
Support x86-64 only instructions on disassembler.
For example, syscall and sysret.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@gmail.com>
---
arch/x86/lib/mnemonic.c | 23 +++++++++++++++++++++--
arch/x86/tools/gen-insn-mnemonic-x86.awk | 11 +++++++++--
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/arch/x86/lib/mnemonic.c b/arch/x86/lib/mnemonic.c
index 0c375fb..dfd1aab 100644
--- a/arch/x86/lib/mnemonic.c
+++ b/arch/x86/lib/mnemonic.c
@@ -1,10 +1,29 @@
#include <linux/kernel.h>
+#include <linux/string.h>
#include <asm/insn.h>
#include <asm/disasm.h>
/* Define mnemonic lookup table */
#include "mnemonic-tables.c"
+static const char *get_variant(const char *fmt, struct insn *insn)
+{
+ const char *p;
+
+ if (!fmt)
+ goto out;
+
+ if (insn->x86_64) {
+ p = strstr(fmt, "%6");
+ if (!p)
+ goto out;
+ fmt = strchr(p, ':') + 1;
+ } else if (strstr(fmt, "%6") == fmt)
+ fmt = NULL;
+out:
+ return fmt;
+}
+
const char *get_mnemonic_format(struct insn *insn, const char **grp)
{
insn_attr_t attr;
@@ -39,7 +58,7 @@ const char *get_mnemonic_format(struct insn *insn, const char **grp)
table = mnemonic_escape_tables[n][0];
}
if (table)
- ret = table[idx];
+ ret = get_variant(table[idx], insn);
/* Solve groups */
if (grp && inat_is_group(attr)) {
@@ -51,7 +70,7 @@ const char *get_mnemonic_format(struct insn *insn, const char **grp)
else
table = mnemonic_group_tables[n][0];
idx = X86_MODRM_REG(idx);
- *grp = table[idx];
+ *grp = get_variant(table[idx], insn);
}
}
return ret;
diff --git a/arch/x86/tools/gen-insn-mnemonic-x86.awk b/arch/x86/tools/gen-insn-mnemonic-x86.awk
index 2714f2f..14fca68 100644
--- a/arch/x86/tools/gen-insn-mnemonic-x86.awk
+++ b/arch/x86/tools/gen-insn-mnemonic-x86.awk
@@ -49,6 +49,7 @@ BEGIN {
regs_expr = "^[ABCDESR][0-9A-Z]"
vregs_expr = "^[re][0-9A-Z]"
+ only64_expr = "\\(o64\\)"
lprefix1_expr = "\\(66\\)"
lprefix2_expr = "\\(F3\\)"
lprefix3_expr = "\\(F2\\)"
@@ -254,6 +255,7 @@ function get_operand(opnd, i,count,f8,opnds) {
ext = null
flags = null
opnd = null
+ pfx = ""
# parse one opcode
if (match($i, opnd_expr))
opnd = get_operand($(i++))
@@ -283,10 +285,15 @@ function get_operand(opnd, i,count,f8,opnds) {
opcode = "call"
if (match(opcode, "^ret.*"))
opcode = "ret"
+
+ # additional flags
+ if (match(ext, only64_expr))
+ pfx = "%6:"
+
if (length(opnd) != 0)
- flags = "\"" opcode " " opnd "\""
+ flags = "\"" pfx opcode " " opnd "\""
else
- flags = "\"" opcode "\""
+ flags = "\"" pfx opcode "\""
if (length(flags) == 0)
continue
next prev parent reply other threads:[~2012-04-01 16:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 16:02 [RFC PATCH -tip 00/16] in-kernel x86 disassember Masami Hiramatsu
2012-04-01 16:02 ` [RFC PATCH -tip 01/16] x86: Split default64 flag from force64 flag Masami Hiramatsu
2012-04-01 16:02 ` [RFC PATCH -tip 02/16] x86: Change the order of segment prefix macro Masami Hiramatsu
2012-04-01 16:02 ` [RFC PATCH -tip 03/16] x86: Add bogus disassembler support Masami Hiramatsu
2012-04-01 16:03 ` [RFC PATCH -tip 04/16] x86: Show kernel symbol in disassembler Masami Hiramatsu
2012-04-01 16:03 ` Masami Hiramatsu [this message]
2012-04-01 16:03 ` [RFC PATCH -tip 06/16] x86: Change asm syntax to AT&T-like one Masami Hiramatsu
2012-04-01 16:03 ` [RFC PATCH -tip 07/16] kdb: Provide original instruction modified by sw breakpoint Masami Hiramatsu
2012-04-01 16:03 ` [RFC PATCH -tip 08/16] x86/kprobes: Recover breakpoint instruction if KGDB knows Masami Hiramatsu
2012-04-01 16:03 ` [RFC PATCH -tip 09/16] x86: kernel function disassembly interface Masami Hiramatsu
2012-04-01 16:03 ` [RFC PATCH -tip 10/16] x86/disasm: Indicate modified instructions Masami Hiramatsu
2012-04-01 16:04 ` [RFC PATCH -tip 11/16] tracing/docs: add explanation about disassembler interface Masami Hiramatsu
2012-04-01 16:04 ` [RFC PATCH -tip 12/16] x86: Merge code dump in show_registers Masami Hiramatsu
2012-04-01 16:04 ` [RFC PATCH -tip 13/16] x86: Disassemble support in register dump Masami Hiramatsu
2012-04-01 16:04 ` [RFC PATCH -tip 14/16] x86: Indicate trapped address and probed address Masami Hiramatsu
2012-04-01 16:04 ` [RFC PATCH -tip 15/16] x86/kdb: Add x86 disassembe command Masami Hiramatsu
2012-04-01 16:05 ` [RFC PATCH -tip 16/16] tools/bogodis: Add bogus disassembler tool in userspace Masami Hiramatsu
2012-04-01 19:58 ` [RFC PATCH -tip 00/16] in-kernel x86 disassember H. Peter Anvin
2012-04-02 7:04 ` Ingo Molnar
2012-04-02 22:17 ` H. Peter Anvin
2012-04-03 7:55 ` Masami Hiramatsu
2012-04-02 22:01 ` H. Peter Anvin
2012-04-03 7:31 ` Ingo Molnar
2012-04-03 8:39 ` Masami Hiramatsu
2012-04-03 16:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401160315.4502.55715.stgit@shimauta \
--to=masami.hiramatsu@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ananth@in.ibm.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox