* [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro
@ 2012-04-02 8:24 Martin Jansa
2012-04-02 12:58 ` Rob Herring
2012-04-02 21:43 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Martin Jansa @ 2012-04-02 8:24 UTC (permalink / raw)
To: Rob Herring
Cc: Martin Jansa, Eric Miao, Russell King, Haojian Zhuang,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:PXA2xx/PXA3xx SUP...,
moderated list:SOUND - SOC LAYER..., open list
* fixes
sound/soc/pxa/pxa2xx-i2s.c:86:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
sound/soc/pxa/pxa2xx-i2s.c:86:2: error: initializer element is not constant
after 23019a733bb83c8499f192fb428b7e6e81c95a34 removed IOMEM
definition from arch/arm/mach-pxa/include/mach/hardware.h
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
sound/soc/pxa/pxa2xx-i2s.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/pxa/pxa2xx-i2s.c b/sound/soc/pxa/pxa2xx-i2s.c
index 609abd5..d085837 100644
--- a/sound/soc/pxa/pxa2xx-i2s.c
+++ b/sound/soc/pxa/pxa2xx-i2s.c
@@ -17,6 +17,7 @@
#include <linux/delay.h>
#include <linux/clk.h>
#include <linux/platform_device.h>
+#include <linux/io.h>
#include <sound/core.h>
#include <sound/pcm.h>
#include <sound/initval.h>
--
1.7.8.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro
2012-04-02 8:24 [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro Martin Jansa
@ 2012-04-02 12:58 ` Rob Herring
2012-04-02 21:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2012-04-02 12:58 UTC (permalink / raw)
To: Martin Jansa
Cc: moderated list:SOUND - SOC LAYER..., Russell King, Takashi Iwai,
Mark Brown, open list, Haojian Zhuang, Jaroslav Kysela, Eric Miao,
Liam Girdwood, moderated list:PXA2xx/PXA3xx SUP...
On 04/02/2012 03:24 AM, Martin Jansa wrote:
> * fixes
> sound/soc/pxa/pxa2xx-i2s.c:86:2: error: implicit declaration of function 'IOMEM' [-Werror=implicit-function-declaration]
> sound/soc/pxa/pxa2xx-i2s.c:86:2: error: initializer element is not constant
> after 23019a733bb83c8499f192fb428b7e6e81c95a34 removed IOMEM
> definition from arch/arm/mach-pxa/include/mach/hardware.h
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
> ---
> sound/soc/pxa/pxa2xx-i2s.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/pxa/pxa2xx-i2s.c b/sound/soc/pxa/pxa2xx-i2s.c
> index 609abd5..d085837 100644
> --- a/sound/soc/pxa/pxa2xx-i2s.c
> +++ b/sound/soc/pxa/pxa2xx-i2s.c
> @@ -17,6 +17,7 @@
> #include <linux/delay.h>
> #include <linux/clk.h>
> #include <linux/platform_device.h>
> +#include <linux/io.h>
> #include <sound/core.h>
> #include <sound/pcm.h>
> #include <sound/initval.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro
2012-04-02 8:24 [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro Martin Jansa
2012-04-02 12:58 ` Rob Herring
@ 2012-04-02 21:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-04-02 21:43 UTC (permalink / raw)
To: Martin Jansa
Cc: Rob Herring, Eric Miao, Russell King, Haojian Zhuang,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
moderated list:PXA2xx/PXA3xx SUP...,
moderated list:SOUND - SOC LAYER..., open list
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Mon, Apr 02, 2012 at 10:24:08AM +0200, Martin Jansa wrote:
> * fixes
*Please* make some effort to use subject lines appropriate to your
patches. I just about deleted this unread because it doesn't mention
anything to do with audio.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-02 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-02 8:24 [PATCH] ARM: pxa: pxa2xx-i2s: add io.h for IOMEM macro Martin Jansa
2012-04-02 12:58 ` Rob Herring
2012-04-02 21:43 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).