From: "Rémi Denis-Courmont" <remi@remlab.net>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: remi.denis-courmont@nokia.com, davem@davemloft.net,
davej@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phonet: Check input from user before allocating
Date: Mon, 2 Apr 2012 22:01:40 +0300 [thread overview]
Message-ID: <201204022201.41808.remi@remlab.net> (raw)
In-Reply-To: <1333398660-11552-1-git-send-email-levinsasha928@gmail.com>
Le lundi 2 avril 2012 23:31:00 Sasha Levin, vous avez écrit :
> A phonet packet is limited to USHRT_MAX bytes, this is never checked during
> tx which means that the user can specify any size he wishes, and the kernel
> will attempt to allocate that size.
Does this really solve the problem? I guess 128kb is still possible with
USHRT_MAX plus skbuff overhead, which might still trigger OOM relatively
easily once the memory gets sufficiently fragmented.
How does UDP deal with this?
--
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis
next prev parent reply other threads:[~2012-04-02 19:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 20:31 [PATCH] phonet: Check input from user before allocating Sasha Levin
2012-04-02 19:00 ` Rémi Denis-Courmont
2012-04-02 21:38 ` David Miller
2012-04-02 19:01 ` Rémi Denis-Courmont [this message]
2012-04-02 21:40 ` David Miller
2012-04-03 1:53 ` Eric Dumazet
2012-04-03 1:59 ` David Miller
2012-04-03 2:15 ` Eric Dumazet
2012-04-03 2:23 ` David Miller
2012-04-03 2:29 ` Eric Dumazet
2012-04-03 2:29 ` Rick Jones
2012-04-03 2:34 ` Eric Dumazet
2012-04-03 2:39 ` Rick Jones
2012-04-03 3:14 ` Eric Dumazet
2012-04-03 18:18 ` Rick Jones
2012-04-03 6:36 ` Rémi Denis-Courmont
2012-04-03 6:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204022201.41808.remi@remlab.net \
--to=remi@remlab.net \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).