From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Shankarmurthy, Akshay" <akshay.s@ti.com>
Cc: <linux-serial@vger.kernel.org>, <alan@linux.intel.com>,
<gregkh@linuxfoundation.org>, <paul.gortmaker@windriver.com>,
<jamie@jamieiles.com>, <swarren@nvidia.com>,
<dianders@chromium.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-kernel@vger.kernel.org>,
Chaithrika U S <chaithrika@ti.com>
Subject: Re: [PATCH] serial: 8250: Add cpufreq support
Date: Tue, 3 Apr 2012 10:55:30 +0100 [thread overview]
Message-ID: <20120403105530.7fa3bce7@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1333433022-5455-1-git-send-email-akshay.s@ti.com>
> This patch was submitted 2 years ago but didn't make it to the mainline. Now i am reposting it.
Can you fix it instead of just reposting it ?
> +#ifdef CONFIG_CPU_FREQ
> +static int serial8250_cpufreq_transition(struct notifier_block *nb,
> + unsigned long val, void *data)
> +{
> + struct uart_8250_port *p;
> + struct uart_port *uport;
What is your locking model ?
> +static inline void serial8250_cpufreq_deregister(struct uart_8250_port *p)
unregister
> + ret = serial8250_cpufreq_register(uart);
> + if (ret < 0)
> + printk(KERN_ERR "Failed to add cpufreq notifier\n");
Why do this for devices that don't care.
Alan
next prev parent reply other threads:[~2012-04-03 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 6:03 [PATCH] serial: 8250: Add cpufreq support Shankarmurthy, Akshay
2012-04-03 9:55 ` Alan Cox [this message]
2012-04-05 10:40 ` Shankarmurthy, Akshay
2012-04-05 10:53 ` Alan Cox
2012-04-12 5:21 ` Shankarmurthy, Akshay
2012-04-12 9:47 ` Alan Cox
2012-04-17 9:43 ` Shankarmurthy, Akshay
2012-04-18 19:47 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2010-01-13 12:35 Chaithrika U S
2010-01-13 13:44 ` Alan Cox
2010-01-18 13:17 ` Chaithrika U S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403105530.7fa3bce7@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akshay.s@ti.com \
--cc=alan@linux.intel.com \
--cc=chaithrika@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox