* [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file
@ 2012-04-03 8:42 Sachin Kamat
2012-04-03 14:59 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-04-03 8:42 UTC (permalink / raw)
To: linux-kernel; +Cc: grant.likely, linus.walleij, ben, sachin.kamat, patches
Fixes the following warning when "SAMSUNG EXYNOS5" is not selected:
warning: ‘exynos5_gpios_1’ defined but not used [-Wunused-variable]
warning: ‘exynos5_gpios_2’ defined but not used [-Wunused-variable]
warning: ‘exynos5_gpios_3’ defined but not used [-Wunused-variable]
warning: ‘exynos5_gpios_4’ defined but not used [-Wunused-variable]
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/gpio/gpio-samsung.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index 4627787..19d6fc0 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -2382,8 +2382,8 @@ static struct samsung_gpio_chip exynos4_gpios_3[] = {
#endif
};
-static struct samsung_gpio_chip exynos5_gpios_1[] = {
#ifdef CONFIG_ARCH_EXYNOS5
+static struct samsung_gpio_chip exynos5_gpios_1[] = {
{
.chip = {
.base = EXYNOS5_GPA0(0),
@@ -2541,11 +2541,11 @@ static struct samsung_gpio_chip exynos5_gpios_1[] = {
.to_irq = samsung_gpiolib_to_irq,
},
},
-#endif
};
+#endif
-static struct samsung_gpio_chip exynos5_gpios_2[] = {
#ifdef CONFIG_ARCH_EXYNOS5
+static struct samsung_gpio_chip exynos5_gpios_2[] = {
{
.chip = {
.base = EXYNOS5_GPE0(0),
@@ -2602,11 +2602,11 @@ static struct samsung_gpio_chip exynos5_gpios_2[] = {
},
},
-#endif
};
+#endif
-static struct samsung_gpio_chip exynos5_gpios_3[] = {
#ifdef CONFIG_ARCH_EXYNOS5
+static struct samsung_gpio_chip exynos5_gpios_3[] = {
{
.chip = {
.base = EXYNOS5_GPV0(0),
@@ -2638,11 +2638,11 @@ static struct samsung_gpio_chip exynos5_gpios_3[] = {
.label = "GPV4",
},
},
-#endif
};
+#endif
-static struct samsung_gpio_chip exynos5_gpios_4[] = {
#ifdef CONFIG_ARCH_EXYNOS5
+static struct samsung_gpio_chip exynos5_gpios_4[] = {
{
.chip = {
.base = EXYNOS5_GPZ(0),
@@ -2650,8 +2650,8 @@ static struct samsung_gpio_chip exynos5_gpios_4[] = {
.label = "GPZ",
},
},
-#endif
};
+#endif
#if defined(CONFIG_ARCH_EXYNOS) && defined(CONFIG_OF)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file
2012-04-03 8:42 [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file Sachin Kamat
@ 2012-04-03 14:59 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-04-03 14:59 UTC (permalink / raw)
To: Sachin Kamat, linux-kernel; +Cc: linus.walleij, ben, sachin.kamat, patches
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]
On Tue, 3 Apr 2012 14:12:55 +0530, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Fixes the following warning when "SAMSUNG EXYNOS5" is not selected:
>
> warning: ‘exynos5_gpios_1’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_2’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_3’ defined but not used [-Wunused-variable]
> warning: ‘exynos5_gpios_4’ defined but not used [-Wunused-variable]
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-samsung.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 4627787..19d6fc0 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -2382,8 +2382,8 @@ static struct samsung_gpio_chip exynos4_gpios_3[] = {
> #endif
> };
>
> -static struct samsung_gpio_chip exynos5_gpios_1[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_1[] = {
> {
> .chip = {
> .base = EXYNOS5_GPA0(0),
> @@ -2541,11 +2541,11 @@ static struct samsung_gpio_chip exynos5_gpios_1[] = {
> .to_irq = samsung_gpiolib_to_irq,
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_2[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_2[] = {
> {
> .chip = {
> .base = EXYNOS5_GPE0(0),
> @@ -2602,11 +2602,11 @@ static struct samsung_gpio_chip exynos5_gpios_2[] = {
>
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_3[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_3[] = {
> {
> .chip = {
> .base = EXYNOS5_GPV0(0),
> @@ -2638,11 +2638,11 @@ static struct samsung_gpio_chip exynos5_gpios_3[] = {
> .label = "GPV4",
> },
> },
> -#endif
> };
> +#endif
>
> -static struct samsung_gpio_chip exynos5_gpios_4[] = {
> #ifdef CONFIG_ARCH_EXYNOS5
> +static struct samsung_gpio_chip exynos5_gpios_4[] = {
> {
> .chip = {
> .base = EXYNOS5_GPZ(0),
> @@ -2650,8 +2650,8 @@ static struct samsung_gpio_chip exynos5_gpios_4[] = {
> .label = "GPZ",
> },
> },
> -#endif
> };
> +#endif
>
>
> #if defined(CONFIG_ARCH_EXYNOS) && defined(CONFIG_OF)
> --
> 1.7.4.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-03 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-03 8:42 [PATCH] ARM: EXYNOS: Fix compiler warning in gpio-samsung.c file Sachin Kamat
2012-04-03 14:59 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).