From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755006Ab2DCRLe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Apr 2012 13:11:34 -0400
Received: from sous-sol.org ([216.99.217.87]:44141 "EHLO sequoia.sous-sol.org"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1753001Ab2DCRLd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Apr 2012 13:11:33 -0400
Date: Tue, 3 Apr 2012 10:11:12 -0700
From: Chris Wright <chrisw@sous-sol.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Chris Wright <chrisw@sous-sol.org>, Ivo Sieben <meltedpianoman@gmail.com>,
        linux-kernel@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
        Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH-v3] Support M95040 SPI EEPROM
Message-ID: <20120403171112.GH19952@sequoia.sous-sol.org>
References: <1333434302-14897-1-git-send-email-meltedpianoman@gmail.com>
 <20120403165320.GG19952@sequoia.sous-sol.org>
 <20120403170708.GC2477@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120403170708.GC2477@pengutronix.de>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Wolfram Sang (w.sang@pengutronix.de) wrote:
> On Tue, Apr 03, 2012 at 09:53:20AM -0700, Chris Wright wrote:
> > * Ivo Sieben (meltedpianoman@gmail.com) wrote:
> > > +	instr = AT25_READ;
> > > +	if (at25->chip.flags & EE_INSTR_BIT3_IS_ADDR)
> > > +		if (offset >= (1U << (at25->addrlen * 8)))
> > > +			instr |= AT25_INSTR_BIT3;
> > > +	*cp++ = instr;
> > <snip>
> > > +	/*
> > > +	 * Certain EEPROMS have a size that is larger than the number of address
> > > +	 * bytes would allow (e.g. like M95040 from ST that has 512 Byte size
> > > +	 * but uses only one address byte (A0 to A7) for addressing.) For
> > > +	 * the extra address bit (A8, A16 or A24) bit 3 of the instruction byte
> > > +	 * is used. This instruction bit is normally defined as don't care for
> > > +	 * other AT25 like chips.
> > > +	 */
> > > +#define EE_INSTR_BIT3_IS_ADDR	0x0010
> > 
> > Is there some guarantee that this chip flag will always have this
> > meaning?
> 
> ? This is a driver flag.

Sorry, I don't see it set anywhere, so unclear on where it comes from.
I thought it was from a generic spi probe.

thanks,
-chris