From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756151Ab2DDJzO (ORCPT ); Wed, 4 Apr 2012 05:55:14 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:48707 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447Ab2DDJzM (ORCPT ); Wed, 4 Apr 2012 05:55:12 -0400 Date: Wed, 4 Apr 2012 11:55:10 +0200 From: Markus Trippelsdorf To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] Fix perf build failure on glibc trunk Message-ID: <20120404095510.GB294@x4> References: <20120404084527.GA294@x4> <20120404094604.GA5930@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120404094604.GA5930@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012.04.04 at 11:46 +0200, Ingo Molnar wrote: > > * Markus Trippelsdorf wrote: > > > On a system running glibc trunk perf doesn't build: > > > > CC builtin-sched.o > > builtin-sched.c: In function ‘get_cpu_usage_nsec_parent’: > > builtin-sched.c:399:16: error: storage size of ‘ru’ isn’t known > > builtin-sched.c:403:2: error: implicit declaration of function ‘getrusage’ [-Werror=implicit-function-declaration] > > builtin-sched.c:403:2: error: nested extern declaration of ‘getrusage’ [-Werror=nested-externs] > > builtin-sched.c:403:18: error: ‘RUSAGE_SELF’ undeclared (first use in this function) > > builtin-sched.c:403:18: note: each undeclared identifier is reported only once for each function it appears in > > builtin-sched.c:399:16: error: unused variable ‘ru’ [-Werror=unused-variable] > > cc1: all warnings being treated as errors > > > > Fix it by including sys/resource.h. > > --- > > tools/perf/builtin-sched.c | 1 + > > 1 file changed, 1 insertion(+) > > Can I add: > > Signed-off-by: Markus Trippelsdorf Yes sure. Sorry. -- Markus