[PATCH] Do notify userspace when there is change in uts_kern_table.

[PATCH] Do notify userspace when there is change in uts_kern_table.

[Sasikantha babu]

sethostname and setdomainname notifies userspace on failure (without modifying uts_kern_table) too

Notify userspace if there is change in uts_kern_table, on failure don't notify userspace 

Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
---
 kernel/sys.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index e7006eb..6c569a8 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1295,8 +1295,8 @@ SYSCALL_DEFINE2(sethostname, char __user *, name, int, len)
 		memcpy(u->nodename, tmp, len);
 		memset(u->nodename + len, 0, sizeof(u->nodename) - len);
 		errno = 0;
+		uts_proc_notify(UTS_PROC_HOSTNAME);
 	}
-	uts_proc_notify(UTS_PROC_HOSTNAME);
 	up_write(&uts_sem);
 	return errno;
 }
@@ -1346,8 +1346,8 @@ SYSCALL_DEFINE2(setdomainname, char __user *, name, int, len)
 		memcpy(u->domainname, tmp, len);
 		memset(u->domainname + len, 0, sizeof(u->domainname) - len);
 		errno = 0;
+		uts_proc_notify(UTS_PROC_DOMAINNAME);
 	}
-	uts_proc_notify(UTS_PROC_DOMAINNAME);
 	up_write(&uts_sem);
 	return errno;
 }
-- 
1.7.3.4

Re: [PATCH] Do notify userspace when there is change in uts_kern_table.

[Cyrill Gorcunov]

On Wed, Apr 04, 2012 at 05:06:31PM +0530, Sasikantha babu wrote:
> sethostname and setdomainname notifies userspace on failure (without modifying uts_kern_table) too
> 
> Notify userspace if there is change in uts_kern_table, on failure don't notify userspace 
> 
> Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>

Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>

Looks reasonable to me.

Re: [PATCH] Do notify userspace when there is change in uts_kern_table.

[Cyrill Gorcunov]

On Thu, Apr 19, 2012 at 08:04:30PM +0530, Sasikanth babu wrote:
> Any comments on this patch?.
> 

Dont top-post please. As I said, it's looks reasonable to me.
Now it's up to maintainers to decide if the patch should be
taken or not.

> > > Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
> >
> > Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
> >
> > Looks reasonable to me.
> >

	Cyrill