From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] regmap: add MMIO bus support
Date: Thu, 5 Apr 2012 09:38:06 +0100 [thread overview]
Message-ID: <20120405083805.GA3129@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F7CD61E.8000609@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Wed, Apr 04, 2012 at 05:15:42PM -0600, Stephen Warren wrote:
> I assume the solution here is to:
> * Always use __raw_readl/__raw_writel in regmap-mmio.c so that there's
> never any endianness conversion, and don't use the endianness conversion
> macros when reading/writing the work buffer.
> * Implement alternative formatters that format in LE instead of BE
> * Add a field to regmap_config indicating which endianness the data
> should be in, and use this flag to select the LE/BE formatters.
> Does that sound about right?
Sounds about right, yes - probably worth having a third option for the
formatting which does no translation for on-SoC device.
> > Given that you constrain on registration too this should be BUG_ON(),
> > we're seriously confused if we're specifying a different register size
> > here and -EIO is going to be a bit obscure.
> I wondered about that. I would have been quite happy to repost with that
> change. Do you want an incremental patch?
Yes, please.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-05 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 21:48 [PATCH 1/6] regmap: introduce fast_io busses, and use a spinlock for them Stephen Warren
2012-04-04 21:48 ` [PATCH 2/6] regmap: allow regmap instances to be named Stephen Warren
2012-04-06 3:44 ` Paul Gortmaker
2012-04-06 5:12 ` Stephen Warren
2012-04-04 21:48 ` [PATCH 3/6] regmap: introduce explicit bus_context for bus callbacks Stephen Warren
2012-04-04 21:48 ` [PATCH 4/6] regmap: add MMIO bus support Stephen Warren
2012-04-04 22:59 ` Mark Brown
2012-04-04 23:15 ` Stephen Warren
2012-04-05 8:38 ` Mark Brown [this message]
2012-04-04 21:48 ` [PATCH 5/6] regmap: add runtime PM calls to debugfs file IO Stephen Warren
2012-04-04 22:19 ` Mark Brown
2012-04-04 21:48 ` [PATCH 6/6] regmap: prevent division by zero in rbtree_show Stephen Warren
2012-04-04 22:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405083805.GA3129@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox