From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: Silence uninitialized variable warning for wm8994-core
Date: Thu, 5 Apr 2012 10:57:55 +0100 [thread overview]
Message-ID: <20120405095754.GF3129@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1333597752.10597.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Thu, Apr 05, 2012 at 11:49:12AM +0800, Axel Lin wrote:
> - int ret, i, patch_regs;
> + int ret, i, patch_regs = 0;
This just unconditionally squashes any possible warnings from this which
isn't great. If we're going to work around flow analysis bugs like this
it's better to do it by doing something like adding an assignment in the
paths that GCC isn't figuring out than by just squashing everything.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-05 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 3:49 [PATCH] mfd: Silence uninitialized variable warning for wm8994-core Axel Lin
2012-04-05 9:57 ` Mark Brown [this message]
2012-04-16 15:37 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405095754.GF3129@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox