From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932490Ab2DFX61 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Apr 2012 19:58:27 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:38310 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754540Ab2DFX60 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Apr 2012 19:58:26 -0400
Date: Fri, 6 Apr 2012 16:58:24 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: David Rientjes <rientjes@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT pull] timer updates for 3.4-rc
Message-Id: <20120406165824.c2ae2719.akpm@linux-foundation.org>
In-Reply-To: <alpine.LFD.2.02.1204070148420.2542@ionos>
References: <alpine.LFD.2.02.1204070131010.2542@ionos>
	<alpine.DEB.2.00.1204061636260.32765@chino.kir.corp.google.com>
	<alpine.LFD.2.02.1204070148420.2542@ionos>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 7 Apr 2012 01:48:51 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Fri, 6 Apr 2012, David Rientjes wrote:
> 
> > On Sat, 7 Apr 2012, Thomas Gleixner wrote:
> > 
> > > diff --git a/kernel/itimer.c b/kernel/itimer.c
> > > index 22000c3..c70369a 100644
> > > --- a/kernel/itimer.c
> > > +++ b/kernel/itimer.c
> > > @@ -284,8 +284,11 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value,
> > >  	if (value) {
> > >  		if(copy_from_user(&set_buffer, value, sizeof(set_buffer)))
> > >  			return -EFAULT;
> > > -	} else
> > > +	} else {
> > >  		memset((char *) &set_buffer, 0, sizeof(set_buffer));
> > > +		WARN_ONCE(1, "setitimer: new_value pointer is NULL."
> > > +			  " Misfeature support will be removed\n");
> > > +	}
> > >  
> > >  	error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL);
> > >  	if (error || !ovalue)
> > 
> > When I tried doing this for the deprecated /proc/pid/oom_adj there was a 
> > complaint that WARN_ONCE() screws up log parsing scripts that think there 
> > is a kernel issue so I had to change it to printk_once() and include 
> > get_task_comm(current) and current->pid.  See
> > http://lkml.indiana.edu/hypermail/linux/kernel/1108.0/00446.html
> 
> Bah.

It gives you a chance to remove the unneeded cast from the memset call ;)