From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758374Ab2DFXae (ORCPT ); Fri, 6 Apr 2012 19:30:34 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53391 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758305Ab2DFXaI (ORCPT ); Fri, 6 Apr 2012 19:30:08 -0400 X-Sasl-enc: wLziDd8as4atOBdunqZ6eCXIkEj6IpxASEOkop0vRgO3 1333755007 Date: Fri, 6 Apr 2012 16:30:04 -0700 From: Greg KH To: Asai Thambi S P Cc: Jens Axboe , "linux-kernel@vger.kernel.org" , Sam Bradshaw Subject: Re: [PATCH 2/5] mtip32xx: Add new sysfs entry 'status' and fix restart port Message-ID: <20120406233004.GA24121@kroah.com> References: <4F7E07DC.50909@micron.com> <20120406011037.GA25892@kroah.com> <4F7F322B.6060805@micron.com> <4F7F615B.80305@micron.com> <20120406214426.GA12772@kroah.com> <4F7F682C.9050806@micron.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F7F682C.9050806@micron.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 06, 2012 at 03:03:24PM -0700, Asai Thambi S P wrote: > On 4/6/2012 2:44 PM, Greg KH wrote: > > > On Fri, Apr 06, 2012 at 02:34:19PM -0700, Asai Thambi S P wrote: > >> On 4/6/2012 11:12 AM, Asai Thambi S P wrote: > >> > >>> On 4/5/2012 6:10 PM, Greg KH wrote: > >>> > >>>> On Thu, Apr 05, 2012 at 02:00:12PM -0700, Asai Thambi S P wrote: > >>>>> > >>>>> * Add support for detecting the following device status > >>>>> - write protect > >>>>> - over temp (thermal shutdown) > >>>>> * New sysfs entry 'status' created for this device, possible values - online, write_protect, thermal_shutdown > >>>> > >>>> All new (and existing) sysfs files must be documented in > >>>> Documentation/ABI/ please do so for these new ones when you add them to > >>>> the kernel. > >>> > >>> > >>> I was not aware of this. Thanks. I will a add new file for mtip32xx driver. > >>> > >> > >> > >> Greg, > >> > >> The sysfs entry for the disk is > >> /sys/block/rssda -> ../devices/pci0000:00/0000:00:01.0/0000:01:00.0/block/rssda > >> > >> Should I use /sys/block// or > >> /sys/devices/.../block//entry> in the doc file? > > > > What do the existing api files show for block devices? > > > > > I was looking into sysfs-driver-* files to create sysfs-driver-mtip32xx. > These files have paths like /sys/bus/pci/*, /sys/devices/*, > /sys/class/bluetooth/*, etc. > > There are sysfs-block-dm and sysfs-block-zram files with > /sys/block/dm-/dm/* and /sys/block/zram/*. If I have to follow > these, then the file would be sysfs-driver-rssd with /sys/block//*. > > Let me know. /sys/block/rs*/ would be the right place, right? You know the tree better than I do as you have this hardware and can see where in sysfs the files really are :) thanks, greg k-h