From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753804Ab2DGLiz (ORCPT ); Sat, 7 Apr 2012 07:38:55 -0400 Received: from mail-1-out2.atlantis.sk ([80.94.52.71]:59732 "EHLO mail.atlantis.sk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753727Ab2DGLix (ORCPT ); Sat, 7 Apr 2012 07:38:53 -0400 From: Ondrej Zary To: Paul Mundt Subject: Re: [PATCH] kyrofb: fix on x86_64 Date: Sat, 7 Apr 2012 13:38:27 +0200 User-Agent: KMail/1.9.10 Cc: Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, Kernel development list References: <201203212336.55396.linux@rainbow-software.org> <20120322000104.GB26543@linux-sh.org> In-Reply-To: <20120322000104.GB26543@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201204071338.30521.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 22 March 2012 01:01:05 Paul Mundt wrote: > On Wed, Mar 21, 2012 at 11:36:50PM +0100, Ondrej Zary wrote: > > kyrofb is completely broken on x86_64 because the registers are defined > > as unsigned long. Change them to u32 to make the driver work. > > Tested with Hercules 3D Prophet 4000XT. > > > > Signed-off-by: Ondrej Zary > > Looks fine to me. > > Acked-by: Paul Mundt When will this go in? -- Ondrej Zary