From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Dongsu Park <advance38@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: tools/virtio: Compile errors
Date: Mon, 9 Apr 2012 10:33:00 +0300 [thread overview]
Message-ID: <20120409073258.GB12014@redhat.com> (raw)
In-Reply-To: <CAEH94Lgha0Ug2Tk9-22=B58tb9xWG5knAfB04aVbW63F5Xi6TA@mail.gmail.com>
On Mon, Apr 09, 2012 at 02:02:53PM +0800, Zhi Yong Wu wrote:
> On Thu, Feb 9, 2012 at 12:47 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Wed, Feb 08, 2012 at 05:04:05PM +0100, Dongsu Park wrote:
> >> Hi,
> >>
> >> there are compile problems under tools/virtio.
> >> If I simply run make,
> >>
> >> ~/linuxsrc/linux-3.2/tools/virtio $ make
> >> gcc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> >> -fno-strict-overflow -MMD -c -o virtio_ring.o
> >> ../../drivers/virtio/virtio_ring.c
> >> ../../drivers/virtio/virtio_ring.c:24:26: fatal error: linux/module.h:
> >> No such file or directory
> >> compilation terminated.
> >> make: *** [virtio_ring.o] Error 1
> >
> >
> >> By the way, my system is Ubuntu 11.10 with Kernel 3.2.
> >>
> >> Cheers,
> >> Dongsu
> >
> > This patch is missing - I'll put it upstream.
> >
> > --->
> >
> > tools/virtio: add module.h stub
> >
> > make it build with linux 3.2
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h
> > new file mode 100644
> > index 0000000..96868eb
> > --- /dev/null
> > +++ b/tools/virtio/linux/module.h
> > @@ -0,0 +1,3 @@
> > +#ifndef LINUX_MODULE_H
> > +#define LINUX_MODULE_H
> > +#endif
> After the patch was applied in my env, i met another issue.
> [root@f15 virtio]# make test
> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
> -fno-strict-overflow -MMD -c -o virtio_ring.o
> ../../drivers/virtio/virtio_ring.c
> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_add_buf\u2019:
> ../../drivers/virtio/virtio_ring.c:277:2: warning: implicit
> declaration of function \u2018wmb\u2019
> [-Wimplicit-function-declaration]
> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_get_buf\u2019:
> ../../drivers/virtio/virtio_ring.c:437:2: warning: implicit
> declaration of function \u2018rmb\u2019
> [-Wimplicit-function-declaration]
> cc virtio_test.o virtio_ring.o -o virtio_test
> virtio_ring.o: In function `virtqueue_add_buf':
> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:277:
> undefined reference to `wmb'
> virtio_ring.o: In function `virtqueue_get_buf':
> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:437:
> undefined reference to `rmb'
> collect2: ld returned 1 exit status
> make: *** [virtio_test] Error 1
On which kernel version does this trigger?
>
>
> --
> Regards,
>
> Zhi Yong Wu
next prev parent reply other threads:[~2012-04-09 7:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:04 tools/virtio: Compile errors Dongsu Park
2012-02-08 16:11 ` devendra.aaru
2012-02-08 16:38 ` Dongsu Park
2012-02-08 16:47 ` Michael S. Tsirkin
2012-04-09 6:02 ` Zhi Yong Wu
2012-04-09 7:33 ` Michael S. Tsirkin [this message]
2012-04-09 7:41 ` Zhi Yong Wu
2012-04-09 7:55 ` Michael S. Tsirkin
2012-04-09 8:49 ` Zhi Yong Wu
2012-04-09 9:00 ` Michael S. Tsirkin
2012-04-09 6:12 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409073258.GB12014@redhat.com \
--to=mst@redhat.com \
--cc=advance38@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).