From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755684Ab2DIHzg (ORCPT ); Mon, 9 Apr 2012 03:55:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754609Ab2DIHzf (ORCPT ); Mon, 9 Apr 2012 03:55:35 -0400 Date: Mon, 9 Apr 2012 10:55:48 +0300 From: "Michael S. Tsirkin" To: Zhi Yong Wu Cc: Dongsu Park , linux-kernel@vger.kernel.org Subject: Re: tools/virtio: Compile errors Message-ID: <20120409075548.GC27771@redhat.com> References: <20120208160405.GA1587@gmail.com> <20120208164736.GA31066@redhat.com> <20120409073258.GB12014@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 09, 2012 at 03:41:36PM +0800, Zhi Yong Wu wrote: > On Mon, Apr 9, 2012 at 3:33 PM, Michael S. Tsirkin wrote: > > On Mon, Apr 09, 2012 at 02:02:53PM +0800, Zhi Yong Wu wrote: > >> On Thu, Feb 9, 2012 at 12:47 AM, Michael S. Tsirkin wrote: > >> > On Wed, Feb 08, 2012 at 05:04:05PM +0100, Dongsu Park wrote: > >> >> Hi, > >> >> > >> >> there are compile problems under tools/virtio. > >> >> If I simply run make, > >> >> > >> >> ~/linuxsrc/linux-3.2/tools/virtio $ make > >> >> gcc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign > >> >> -fno-strict-overflow  -MMD   -c -o virtio_ring.o > >> >> ../../drivers/virtio/virtio_ring.c > >> >> ../../drivers/virtio/virtio_ring.c:24:26: fatal error: linux/module.h: > >> >> No such file or directory > >> >> compilation terminated. > >> >> make: *** [virtio_ring.o] Error 1 > >> > > >> > > >> >> By the way, my system is Ubuntu 11.10 with Kernel 3.2. > >> >> > >> >> Cheers, > >> >> Dongsu > >> > > >> > This patch is missing - I'll put it upstream. > >> > > >> > ---> > >> > > >> > tools/virtio: add module.h stub > >> > > >> > make it build with linux 3.2 > >> > > >> > Signed-off-by: Michael S. Tsirkin > >> > > >> > diff --git a/tools/virtio/linux/module.h b/tools/virtio/linux/module.h > >> > new file mode 100644 > >> > index 0000000..96868eb > >> > --- /dev/null > >> > +++ b/tools/virtio/linux/module.h > >> > @@ -0,0 +1,3 @@ > >> > +#ifndef LINUX_MODULE_H > >> > +#define LINUX_MODULE_H > >> > +#endif > >> After the patch was applied in my env, i met another issue. > >> [root@f15 virtio]# make test > >> cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign > >> -fno-strict-overflow  -MMD   -c -o virtio_ring.o > >> ../../drivers/virtio/virtio_ring.c > >> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_add_buf\u2019: > >> ../../drivers/virtio/virtio_ring.c:277:2: warning: implicit > >> declaration of function \u2018wmb\u2019 > >> [-Wimplicit-function-declaration] > >> ../../drivers/virtio/virtio_ring.c: In function \u2018virtqueue_get_buf\u2019: > >> ../../drivers/virtio/virtio_ring.c:437:2: warning: implicit > >> declaration of function \u2018rmb\u2019 > >> [-Wimplicit-function-declaration] > >> cc   virtio_test.o virtio_ring.o   -o virtio_test > >> virtio_ring.o: In function `virtqueue_add_buf': > >> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:277: > >> undefined reference to `wmb' > >> virtio_ring.o: In function `virtqueue_get_buf': > >> /home/zwu/work/kernel/vhost-scsi/tools/virtio/../../drivers/virtio/virtio_ring.c:437: > >> undefined reference to `rmb' > >> collect2: ld returned 1 exit status > >> make: *** [virtio_test] Error 1 > > > > On which kernel version does this trigger? > [root@f15 linux-2.6]# git log > commit e22057c8599373e5caef0bc42bdb95d2a361ab0d > Merge: 496b919 df7a3ee > Author: Linus Torvalds > Date: Sat Mar 24 12:20:25 2012 -0700 Update to 3.4-rc2 and most of the issues go away (there's still a build breakage with a missing flag to dev_cleanup, I'm fixing this up for now you can just pass false).