From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, linus.walleij@stericsson.com
Subject: Re: [PATCH 2/3] gpio: langwell: allocate IRQ descriptors dynamically for SPARSE_IRQ
Date: Tue, 10 Apr 2012 10:18:59 +0300 [thread overview]
Message-ID: <20120410071859.GA18679@intel.com> (raw)
In-Reply-To: <20120406043414.3B8FF3E0DD7@localhost>
On Thu, Apr 05, 2012 at 09:34:14PM -0700, Grant Likely wrote:
> On Thu, 5 Apr 2012 12:15:16 +0300, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> > Since x86 is using SPARSE_IRQ by default nowadays it means that we need to
> > allocate IRQ descriptors dynamically using irq_alloc_descs() otherwise the
> > genirq code fails to convert our irq numbers to suitable descriptors.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Applied, thakns.
>
> While you're in this driver, you should look at converting to using an
> irq_domain for irq <==> hwirq mapping. At the very least,
> irq_data->hwirq should be used instead of abusing irq_set_chip_data().
Ok, will do. Thanks.
next prev parent reply other threads:[~2012-04-10 7:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 9:15 [PATCH 1/3] gpio: langwell: use devm_* helpers to simplify probe Mika Westerberg
2012-04-05 9:15 ` [PATCH 2/3] gpio: langwell: allocate IRQ descriptors dynamically for SPARSE_IRQ Mika Westerberg
2012-04-06 4:34 ` Grant Likely
2012-04-10 7:18 ` Mika Westerberg [this message]
2012-04-24 10:13 ` Mika Westerberg
2012-04-05 9:15 ` [PATCH 3/3] gpio: langwell: clear IRQ edge detect registers at init Mika Westerberg
2012-04-06 4:39 ` Grant Likely
2012-04-06 4:26 ` [PATCH 1/3] gpio: langwell: use devm_* helpers to simplify probe Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410071859.GA18679@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox